- Merge request !112Issue #3270626: [Taxonomy] Enable Gin edit form by default → (Open) created by saschaeggi
- 🇫🇮Finland sokru
Not most elegant solution, but works for me.
I didn't addentity.taxonomy_vocabulary.add_form
orentity.taxonomy_vocabulary.edit_form
routes to follow same UI as content type edit forms. - First commit to issue fork.
- Merge request !237Issue #3270626: [Taxonomy] Enable Gin edit form by default → (Open) created by dieterholvoet
- 🇧🇪Belgium dieterholvoet Brussels
The last patch only works for vocabularies named 'tags'. I created a MR based on the patch and the changes from the Thunder distribution.
- 🇮🇳India Santosh_Verma
I have tested the MR, But it has conflict, @DieterHolvoet can you please check and update the MR.
Thanks in Advance :) - Status changed to Needs work
over 1 year ago 1:25pm 20 March 2023 - Status changed to Needs review
over 1 year ago 1:31pm 20 March 2023 - 🇧🇪Belgium dieterholvoet Brussels
My bad, I forgot to push my changes. Should work now.
- Assigned to Santosh_Verma
- 🇮🇳India Santosh_Verma
I have tested the MR 237 applied successfully. and solution is working. i have shared the screenshot.
Before
after
Thanks
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 6:50am 21 March 2023 - 🇫🇷France iheb.attia
The patch #2 →
does not work on taxonomy translation pages. I've updated the patch to include the taxonomy translation add and edit route names. - 🇧🇪Belgium dieterholvoet Brussels
@iheb.attia work is being done in the MR, you should test those changes instead of the patch from #2.
- 🇬🇧United Kingdom justanothermark
A couple of suggestions from reviewing the MR:
1. Should we undo moving the `langcode` field in to the sidebar? The node form doesn't do this so doing it for taxonomy terms makes them inconsistent.
2. I think we should include the `entity.taxonomy_term.content_translation_edit` route as well. - Merge request !305Issue #3270626: [Taxonomy] Enable Gin edit form by default → (Closed) created by justanothermark
- First commit to issue fork.
- 🇩🇪Germany Hydra
Just wanted to drop that here as an alternative solution to the patch https://www.drupal.org/project/gin_everywhere →
- Status changed to Needs review
8 months ago 8:37am 9 April 2024 - 🇩🇪Germany volkerk
We need a more in depth review other than posting two screenshots.
- 🇦🇹Austria hudri Austria
Here is a patch file for RC11, suitable for composer patches:
drupal.org/files/issues/2024-06-19/gin_3270626_cherrypick_for_rc11.patch →
Just a cherry-pick of commit ee8cb77e refitted for RC11.
(Please do not use this patch file for issue development, use merge requests to resolve the issue) - 🇧🇪Belgium dieterholvoet Brussels
@justanothermark I cherrypicked your suggestion from MR#305 / comment #23 onto MR#237. I suggest you close MR#305, no need to start a new MR, you can just acquire push access to the existing issue fork and commit there.
- 🇧🇪Belgium dieterholvoet Brussels
DieterHolvoet → changed the visibility of the branch 3270626-taxonomy-integration to hidden.
- 🇧🇪Belgium dieterholvoet Brussels
DieterHolvoet → changed the visibility of the branch 3270626-taxonomy-integration to active.
- 🇧🇪Belgium dieterholvoet Brussels
DieterHolvoet → changed the visibility of the branch 3270626-taxonomy-integration to active.
- 🇧🇪Belgium dieterholvoet Brussels
DieterHolvoet → changed the visibility of the branch 3270626-taxonomy-integration to active.
- 🇩🇪Germany Anybody Porta Westfalica
@saschaeggi wouldn't it make sense to unify the entity create / edit forms in general, providing the sidebar by default?
I'm not aware of the technical reasons why currently only nodes use the sidebar, but from the user / UX perspective the current state seems inconsistent.Users wonder why the Create / edit Taxonomy Term, Product, Block, ... entity forms look different from the node forms they mostly work with.
Another option would be to have a settings page where the entity types can be selected that should use the sidebar?
Should we maybe widen the scope of this issue or is there already an existing plan to unify the UX for all entity forms by default?Thank you!
- 🇺🇦Ukraine Anna D
Tested applicable MR https://git.drupalcode.org/project/gin/-/merge_requests/237
Published checkbox isn't part of gin-sticky-form-actions.