Okay I found out that this is actually working in ckeditor, when the image_sizes/core library gets loaded. For some reason this is not happening when embedded via ckeditor, therefore I added it as a dependency when adding media. It might happen that it gets loaded reasonless, but that was the best I could come up with.
As of #3515950
Can you please review this with the current RC5 version - I tested this with stage_file_proxy and it seems that the original issue is not happening anymore. It's actually failing right now and removing the stage_file_proxy check did already solve the problem for me @drupatz
I am not that deep into the magic of the component, but I tested it and it fixed the issue without creating new ones - so I guess its a good fix :) Thx!
Nice, thx for the fix!
hey thx for testing! This has already been merged to 1.x
Rly nice, thx for the idea adoption!
@all who are using this patch already, pls make sure to adjust your code. Harlor updated the issue summary with an up-to-date documentation.
LGTM
Nice! I'll gonna test this as well in a project and give feedback :)
@woldtwerk Any news on this?
Hi @mohammad faqeh thx for your report!
I see that issue but I don't think we should solve this specifically for media. It is theoretically possible to make some of those fields that belong to the advanced section visible with media and even more important I thin, is that this is actually happening on other entity forms as well (like path_alias for instance and possibly more).
I am totally into fixing this, but I would prefer a solution which would fix that issue in general. Haven't had the possibility to think about a solution yet, I am not even sure this is possible, but before excluding media entities I would suggest trying it :)
So thx again for pointing this out and starting the discussion :)
Yeah just did not have the time yesterday. 1.2.3 is out containing the hotfix.
Maybe we find a better title for this issue if we leave it open?
I am totally fine with your suggestion! Merged.
I merged the 2 pages and tried to make more clear what it's purpose is, I hope thats better :)
Merged the 6/7 versions and made more clear that his is the old module page for documentation purpose.
Thx for the feedback. I just wanted to keep the legacy content from the module page. It's no specific or new documentation. It just for historic reasons and as far as I understood the takeover of the modules namespace maintainership, I should keep old Versions and content.
So basically my Idea was to create those documentation pages and link to them from the modules page. If this is not ok, any Idea how to solve this?
Appreciate any feedback!
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
As this module has not been maintained for some time, I am closing this ticket as “outdated”. A new version of sites which is architecturally and technically unrelated to the Drupal 6 and Drupa 7 versions will be published here soon.
Thank you for your contribution.
Hey @grevil, that made me curious. Some differences I could identify are:
The status field is of type "radios" instead of type "checkbox"
That might be something we could cover by making sure the form element type is correct.
The missing footer container
That could also easily been covered by providing it if non existent.
#tree TRUE
The PromotionForm set's the #tree property to TRUE, which actually breaks the #group functionality. I cannot see a reason right now why this has been done. And I am not sure we can just randomly change that value in gin_everywhere. I did a quick manual check and the form still works when I remove that, but I cannot assure it would not break anything - but have not many stacks in that either so very interested in your opinions!
Hey thx for the great feedback!
Yeah unfortunately those systems don't use the link_generator service for generating the link. Afaik there is no way to alter the \Drupal\Core\Url object - which in those cases is used directly to create the link.
So probably the LinkItem FieldType needs to be replaced to get this working with menu links, I would not mind commiting this if someone wants to work on this.
@jurgenhaas Well since we have a working workaround for the message usecase with https://www.drupal.org/project/eca_message → I'm fine :) I haven't had that case in any other context yet, so I would say there is real no need for action. It's up to you if you want to address this or not. Thanks for getting back to this :)
@grevil Yeah but gin is designed to optimize the NodeForm, not the ContentEntityForm, and NodeForm is doing this:
$form['status']['#group'] = 'footer';
Therefore in order to move the status checkbox field to the position, we need to move it to the footer group. See my screenshot from before:
This looks good to me, if @grevil could confirm this works for his use-case I'll do a release with that imidiatly :)
Hm we could check for status to make sure this does not happen? Just removing this will break integration for forms that have a checkbox status field like media for example.
I see that, I'll do a quick release with that.
Thx! Shame on me that I missed that.
Thx for the suggestion to delete the branch, but it seems like gitlab is preventing the deletion of this branch :(
You are welcome! Really appreciate your feedback and help on this module :)
Oh @rajab natshah thx for the reminder! I completely forgot to do this on this project. Done :) Version 1.2.0 is out with D11 support!
Hey @peter majmesku! Thx for the work on this. This is a great starting point that will help us continually improving the module, really appreciated!
The MR for @mysdiir worked for my 10.4 setup, thx for that!
I ran into an issue which gave me a hard time to understand whats going on, I'll try my best to describe this:
- Create a new block in a layout
- Save and then switch the language to create a translation for this block
- The block created in the source language now is not shown anymore
What I found out is, that the creation of the translation, created a new revision for all languages. But since blocks in layout_builder are referenced by the block_revision_id, the method isBlockRevisionUsedInEntity in SetInlineBlockDependency no longer returns TRUE when determination of the layout_entity takes place, which will be used to inherit the access to the block. This even get's worse when using a paragraph on that block, which also tries to inherit the access.
I have no idea if the other language versions of the layout should be getting updated or if the isBlockRevisionUsedInEntity method should take the latest affected revision in consideration for it's lookup and of course the block_revision_id from the translation as well (currently it always uses the source for that).
To be sure (because it should be backwards compatible and not changing data) I decided to go for the second approach and created this little helper module, which should be obsolete when this gets fixed, or someone gives me a hint what I am doing wrong :)
@woldtwerk What do you think, should we continue the work? The new JS you showed me in Berlin already looked super promising :) I'd love to see that in before going an 4.0
Probably not, thx for the explanation.
Currently it just provides a form controller using the slots element which can be used for manual testing if needed. It can later be used for FunctionalJavascript testing which has not been implemented yet.