🇩🇪Germany @Hydra

Nice!

In similar cases like paragraphs this is called "status" - should we also call this status instead of "active"?

@Harlor I'd like to rename the checkbox to something more editor focused like "Display this content in slot(s)." as part of the UX enhancements I am working on in https://www.drupal.org/project/slots/issues/3486546 ✨ [META] Make creating slot content more intuitive Active

Should we also use this wording in this context? Otherwise this looks pretty cool :)

The hint in #11 helped me, thx. Since this is clearly the cause of the originally described error message, we should close this.

hydra → created an issue.

hydra → created an issue.

hydra → created an issue.

This needs some extra support from the conditions module.

hydra → created an issue.

hydra → created an issue.

@Harlor I added a fix for the notice directly https://git.drupalcode.org/project/spa/-/commit/a531c2ac0ede3691a879b554...

Not sure if this is enough, but it looks good.

hydra → made their first commit to this issue’s fork.

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

Np, I will checkout the other issue soon and make a release with the fixes.

Well, welcome back on board :)

Hey Peter! Really long time no see! Yeah you are right. The form decorator module decorates all forms this might cause that issue.

hydra → made their first commit to this issue’s fork.

Thx!

hydra → made their first commit to this issue’s fork.

Thx, better then the quickfix I did :)

hydra → made their first commit to this issue’s fork.

Nice!

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

hydra → created an issue.

hydra → made their first commit to this issue’s fork.

This has been fixed in https://www.drupal.org/project/rabbit_hole_links/issues/3481374 🐛 Fatal at /admin/config/search/path Active

hydra → made their first commit to this issue’s fork.

We should do that, thx.

hydra → made their first commit to this issue’s fork.

Hm this breaks decorating the ComponentsTwigExtension service since another namespaced object gets registered as extension to twig. Any idea on how to get around this?

hydra → created an issue.

@woldtwerk You can check out the 4.x version of image_sizes if you want. I replaced the image_sizes JS implementation with yours. I also added you as a maintainer. I build an upgrade path which should also upgrade for image_sizes_extras projects. The new version of image_sizes is build on responsive_image module from core so we don't need to maintain our custom data model anymore.

I will test the 4.x version on my projects and if everything works well I will make a new release. At this point you probably should flag this project as deprecated and lead users to the image_sizes module. Thx!

hydra → created an issue.

LGTM for now

Okay core does not respect this, but when using field_group module this works just fine :)

Actually this has been implemented by accident already when switching to a machine_name field in https://www.drupal.org/project/slots/issues/3477528 🐛 Spaces in slot id Active .

As a result we need to remove this from block ui, otherwise we cannot save blocks anymore.

hydra → made their first commit to this issue’s fork.

It looks like you accidentally added stuff from another patch in here, maybe we should wait till that get commited.

works

hydra → made their first commit to this issue’s fork.

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

hydra → created an issue.

hydra → made their first commit to this issue’s fork.

hydra → changed the visibility of the branch 3477533-cannot-add-condition to hidden.

hydra → created an issue.

This belongs to the conditions module

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

hydra → created an issue.

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

hydra → created an issue.

hydra → created an issue.

hydra → created an issue.

hydra → created an issue.

hydra → created an issue.

@woldtwerk I just started working on this - I will follow Eriks suggestion and replace the JS implementation with yours. There is actually a lot under the hood that will change. I'd like to give you credits for the code I borrow, so please feel free to put yourself in an MR as a contributor/maintainer to the readme or something :)

Ah nice, thx :) I am going to refactor the most of that code anyway but I will commit this already to have this fixed.

hydra → made their first commit to this issue’s fork.

hydra → created an issue.

Hey thx for this feature! I merged it to 3.1.x as a new feature. I will deprecate 1.0 soon after doing some more cleanups in general.

hydra → made their first commit to this issue’s fork.