Use Gin's edit form for Media Entries

another vote for RTBC

$route_names array need also following to support translations:

  'entity.media.content_translation_add'

Updated patch #4 by addressing #8, please review it.

Thanks!

For some reason the media edit and content translation edit forms weren't using the node form, so I added their routes to the route list, which seems to have fixed the problem. I regenerated the patch based on this change and have attached it to this comment.

When the media edit form (and others) are loaded in ajax context (overlays, etc) assure that gin content form layout is not applied.

Just wanted to drop that here as an alternative solution to the patch https://www.drupal.org/project/gin_everywhere →

I finally had the chance to give Gin Everywhere a try last week. In my opinion it’s the way to go.

In fact I’d also suggest making Gin Everywhere one of the Gin ecosystem’s recommended modules.

For now I implemented hook_gin_content_form_routes_alter() to disable gin content form layout for ajax requests:

function thunder_gin_content_form_routes_alter(array &$routes) {
  // Do not use gin content edit form layout in ajax context (overlays).
  if (\Drupal::request()->isXmlHttpRequest()) {
    $routes = [];
  }
}

See also issue for thunder distribution: 🐛 Current Gin version does not work with media_library_edit Active .

@osopolar

\Drupal::request()->isXmlHttpRequest()

Is this still an issue on RC14 or the latest dev? The check you mentioned will break other forms likely (e.g. in webforms, content edit or form displays) as it will replace the sticky actions on any ajax request.

Unfortunately in Drupal Core today, there is no proper way to test for an ajax request coming from an dialog/offcanvas as they often report back just as regular ajax call.

If it's still an issue in some cases, can you try if 📌 Improve sticky actions implementation Active will eventually solve it? Thanks!

@saschaeggi Do you mean it will break the forms or it will just disable the sticky action in many places?

For now I am fine with disabling sticky action. I would have disabled it completely, also for content forms, but there is no option for that. We use the thunder distribution, which pins the gin theme to 3.0.0-rc11, as "The update to current version of gin is quite complicated". I tried to use RC14, but I was not able to save the content form, as the content moderation select field (container) was moved to more actions and from there it did not work. I tried some related patches with no luck and decided to downgrade again, as resources for working on that are very limited.

@osopolar break. We tried many implementations in the last couple of months and relaying on \Drupal::request()->isXmlHttpRequest() did produce a ton of issues. So for example if the first request isn't using Ajax, but once you change something it involves Ajax the buttons will be moved from the sticky actions to the end of the form which can lead so multiple issues.

The whole implementation is rather complicated and we have another improvement being worked on in 📌 Improve sticky actions implementation Active which could use some testing and some helping hands to get this done correctly.

The update to current version of gin is quite complicated

This might be true, but as I haven't heard anything form the Thunder team, I can't speak for what the issues are on their end.