Moving the save button into the toolbar for site builder screen e.g. edit content type

This is also on our roadmap. If you have dev resources to implement this, we can move ahead with this.

Perfect. I will get somebody on this asap!

@HeikeT any news on this? :)

saschaeggi → changed the visibility of the branch 3356717-moving-the-save to hidden.

Looking good and I agree this would be a timesaver.

Only place I still notice the button on the bottom is on block forms.
Might need to add this unless this is an intentional exception.

@LRoels fixed, thank you!

I've pushed another change to include a proof of concept to move other actions to a kebab menu. It uses a container so it would be possible to move things in or out of that menu, but by default we would show all buttons which are not primary functions (submits) to that kebab menu.

We're making big progress here, I'm very exciting to finally have this unified across the UI 🎉

This looks and feels like a nice improvement to the Webform form builder UI. There are a few minor issues that probably need to be fixed via Webform.

For example, the form builder uses Ajax to refresh to table when an element is added or updated. The 'Save' button is fine but the status message is not displaying and fading away.

→

I tested this and moving the action buttons to static on configuration pages is a nice touch!
About the more actions dropdown I had a few thougths.

* Does it make sense to have the more actions functionality only kick in when there is more than a number of actions?
Also might be nice to have that configurable.
* I would suggest that we introduce alter functionality to be able to exclude certain actions from the dropdown button.
* I am not sure about having the meta sidebar toggle inside the more dropdown button. It is somehow central to the edit experience and also shows state?

@volkerk

Does it make sense to have the more actions functionality only kick in when there is more than a number of actions?

I'd rather have it consistent.

I would suggest that we introduce alter functionality to be able to exclude certain actions from the dropdown button.

We actually thought about that as well, if you add '#gin_action_item' => true to form action items, they will always be visible (credit to Jürgen)

I am not sure about having the meta sidebar toggle inside the more dropdown button. It is somehow central to the edit experience and also shows state?

The sidebar can be toggled with a shortcut. But we might want to move the toggle anyway to the sidebar element itself. Can be done in a follow-up though.

saschaeggi → credited Luke.Leber → .

saschaeggi → credited paul121 → .

saschaeggi → credited Rajab Natshah → .

Adding credits from people testing 👀

Thank you everyone involved here! This is a huge deal and will pave the way to integrate this into Core at a later point ❤️✊

Special thanks to Jürgen with all your help, this would habe not been possible without your help!

I could not find any reason why the sidebar icon has been changed? To my eye that looks odd. Can I get some arguments why this has been done?
https://git.drupalcode.org/project/gin/-/merge_requests/420/diffs#6b572a...

Maybe an automatic exception for the delete button could be made? I expect some less technical users losing their mind over the delete button "disappearing" from the form.

Is there a way to get all the options out of the kebab menu? I don't find it very user friendly.

Thank you, Sascha, for having this in Gin + thanks for the API for it.

With further testing and trying to change the logic on the unlock or delete buttons.

After a review with our product owner.
The direction went to follow with the new change by the Gin Admin theme
Only keeping the logic in Issue #3436163 → : Moved the Save as Draft moderation state element next to preview and Save in the Edit content with workflow

When the Workflow module is enabled
Reverting

• 📌 Fix regression for the Action buttons in sticky header, which Gin provided a new API for sticky form actions Needs work
• 🐛 Fix regression for the Action buttons in sticky header, which Gin provided a new API for sticky form actions Fixed

Suggesting that maybe Gin could have support for the Moderation status position, when the workflow module is enabled, and the content/entity is configured to use it.

Automatically closed - issue fixed for 2 weeks with no activity.

@Rajab I tried your code in the hook_form_alter but it doesn't work. How do you use this to exclude items from being hidden?

Hi !

Before version 8.x-3.0 I could create a button/link with the following code:

function hook_form_alter(..) {

      $form['actions']['emailing_preview'] = [
        '#type' => 'link',
        '#title' => t('Preview emailing'),
        '#url' => Url::fromRoute('emailing.Preview', ['nid' => $nid]),
        '#attributes' => [
          'class' => ['button', 'button--secondary', 'use-ajax'],
          'data-dialog-type' => 'modal',
          'data-dialog-options' => Json::encode([
            'classes' => [
              'ui-dialog' => 'modal-emailing-preview',
              'ui-dialog-content' => 'overflow-hidden px-0',
            ],
            'width' => 800,
            'height' => 600
          ]),
        ],
        '#group' => 'gin_actions',
        '#gin_action_item' => TRUE,
      ];
    }

With the 8.x-3.0 version, using a link type element no longer seems to work.

Do we have to use a 'submit' type element to add an action button?

Thanks.