This fix seems to work just fine on the rc1 version.
Even though the beta version does not have the same issue as stated in #2, it seems like a good idea to get it fixed everywhere just in case it should reappear.
Looking good and I agree this would be a timesaver.
Only place I still notice the button on the bottom is on block forms.
Might need to add this unless this is an intentional exception.
Added an updated version of the patch since there was a bug with non existing section storage.
Another update on this:
This seems to be an error with the layout_builder tempstorage.
In our case, we had no concurrent editing and all languages should be in sync.
Because of this, I was able to implement the patch I attached here.
In this patch I added a presave functionality to clear the LB tempstore and thus display the correct layout in de Layout Builder page.
Can confirm this issue. This breaks the editing experience.
On the other hand, in the node view this issue is not present so it does not break the viewing experience.
Seems like a big issue to me.
Can also confirm that the workaround in #2 works. (saving layout builder page of translation)
Just checking: any plans for when you would publish a new release?
Fair point. I got this error while using some config that had this applied on the simple scheduler.
Conclusion: The feature in the initial issue is already in place if you use the crontab scheduler.
Config validation should be able to catch the unsupported simple options.
If the validation is in place, the above fix should not be necessary anymore.
Patch applies on version 2.3.0 and fixes the issue stated above.
Comment in #8 should still be taken into account but marking this as reviewed since it does work and fixes the issue.
Up to the maintainer to see if they want to implement it this way or not.
+1 : Lets get this merged!
Following the comment in #12, here is a new static version of this patch.
Rebased to make sure the latest version is still working.
Seems to work on the latest version.
IMO something we should get in as not everyone is using the default interval settings.
I used git bisect to identify wich Drupal core commit between 10.0.11 and 10.1.0 is the culprit.
Seems like it is this one: https://git.drupalcode.org/project/drupal/-/commit/eb019c17cfba31f5e76eb...
The commit is linked to this drupal core issue:
https://www.drupal.org/node/2457999 →
I posted a notice there as well since I don't really know the scope of that ticket yet.
I traced issues of a DS ticket back to changes in this ticket.
The issue in question is this one:
https://www.drupal.org/project/ds/issues/3394419
🐛
Alternating view mode not working
Active
Anyone that could take a look to see what the issue could be?
I'm seeing the same thing.
I checked with 3.15 on several D10 versions and the problem starts on 10.1.x.
The 10.0.x version does not have this problem.
It seems like the dsPreRender function is not firing properly since that contains the code to set the classes.
Code can be seen here: https://git.drupalcode.org/project/ds/-/blob/8.x-3.15/src/Plugin/views/E...
I think what @tomthorp is describing, is why this is happening in some cases.
I noticed the same thing on our site and with some digging came to the conclusion that by saving the field_settings, there were references to a "title" on the preview field that caused an error. This "title" is only added in the 2.x version and does not exist in the 1.x version.
Because of the downgrade, there is a mismatch on this field.
I don't know if there is any way to fix this mismatch since the field has been created already and is looking for the "title".
Why this is happening after the upgrade from 1.7 to 1.8 is still not clear to me.
Seems to me like we can mark this as RTBC if it is tested and working on a production environment.
Coming back on what is mentioned in #50.
We still get the same behaviour of links and email addresses in ckeditor being recognised as anchor links.
Is there anyone that can confirm this behaviour?
Steps to reproduce:
1. start typing in wysiwyg: test@test.com
2. when you press space, the email gets transformed into an anchor and link, all at once.
See attached mp4 file for reconstruction of what is happening.
Would be nice to see if this is an issue on our side, or if this has something to do with this patch.
Hi, we also still get the error after updating to the 2.0.2 release.
I think it has to do with the lazy class not existing untill 10.1 (
https://www.drupal.org/node/2888767 →
).
We are using D10.0.9. It seems best to keep using the CssCollectionOptimizer class because otherwise the module is not backwards compatible.
Changing the status to needs review for now. Seems wrong to keep it on RTBC.
After the changes in this last commit, the configuration page seems to be broken.
Errors like the one below seem to point at this commit.
TypeError: Drupal\popup_message\Form\PopupMessageSettingsForm::__construct(): Argument #1 ($cssOptimizer) must be of type Drupal\Core\Asset\CssCollectionOptimizerLazy, Drupal\Core\Asset\CssCollectionOptimizer given, called in /var/www/html/web/modules/contrib/popup_message/src/Form/PopupMessageSettingsForm.php on line 81 in Drupal\popup_message\Form\PopupMessageSettingsForm->__construct() (line 66 of modules/contrib/popup_message/src/Form/PopupMessageSettingsForm.php).
Great, thanks a lot for creating the new release!
LRoels → created an issue. See original summary → .