Consider adding a hook to Paragraphs::getSummary

I believe these patches fail in Drupal 10 sites with the error:

Uncaught Error: Class "Symfony\Component\EventDispatcher\Event" not found in modules/contrib/paragraphs/src/Event/ParagraphSummaryAlterEvent.php:4

According to vendor/symfony/event-dispatcher/CHANGELOG.md, in Symfony 5.x

Based on this I think the use statement at the top of src/Event/ParagraphSummaryAlterEvent.php should be updated
from
use Symfony\Component\EventDispatcher\Event;
to
use Symfony\Contracts\EventDispatcher\Event;

for sites that are based on Symfony 5 or above.

@vladigor@gmail.com In patch #38 this class is not used. It uses the class Drupal\Component\EventDispatcher\Event according to change record: https://www.drupal.org/node/3159012 →

Thanks @a.dmitriiev.
I've switched over to patch #38 on my Drupal 10.1.0 site using Paragraphs 1.15.0.
When I try to edit a page that contains paragraphs I get the following error:

TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given, called in /app/docroot/modules/contrib/paragraphs/src/Entity/Paragraph.php on line 468 in Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (line 89 of core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php).

It appears that in Drupal 10.1 the event_dispatcher service uses the dispatch function from ContainerAwareEventDispatcher.php, which expects $event as the first parameter.
Ref. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Even...

I've attached an updated version of patch #38 that switches around the parameters in the two calls to the dispatch function.

Changing the status to needs review for now. Seems wrong to keep it on RTBC.

#42 is working for me with Drupal 10.1.5 and Paragraphs 8.x-1.16

#42 is working for me as well for Drupal 10

Re-rolled #42 patch to check for empty of summary[$type] on appendTextToSummary() and prependTextToSummary() in src/Event/ParagraphSummaryAlterEvent.php

Re-rolled #46 for 1.19.

I have opened MR based on patch #47 for easier review process and maybe it will speed up the merge of the changes.

The MR had missing pieces from the patch, I pushed it.
I attached a patch file for composer patching against 1.19 version.

confirming that the pacth #51 📌 Consider adding a hook to Paragraphs::getSummary RTBC and MR work on:

• Drupal: 10.4.5
• Paragraphs: 1.19.0

In our case we use a ParagraphSummarySubscriber to alter paragraphs summary based on custom conditions, which works as expected using ParagraphSummaryAlterEvent

I can confirm the merge-request code works fine in Drupal 10.4.6.

I am just confused about adding isEmpty for append and prepend methods from #46. I don't see the benefit in having to check the summary in my own code before using appending/prepending.

I don't want to just change it without getting another feedback on this opinion.