I did also try to improve the paragraphs integration. The serialization process being used makes it difficult to understand, what type of structure the library expects.
This seems to have broken something. I tested in on our install profile and I think it worked fine. Now on plain Drupal I get this:
Error: Object of class Drupal\file\Entity\File could not be converted to string in Drupal\Core\Entity\EntityStorageBase->buildCacheId() (line 142 of core/lib/Drupal/Core/Entity/EntityStorageBase.php).
Reopening.
Missed to merge this one.
Rebased. Now merging this.
Thx.
Better approach in ✨ Provide a way to download custom size Active . Closing this one.
Thanks all
Thanks for this. Overall it seems to work fine. I just did a bit of cleanup mostly to avoid already saving the file.
Seems like fit=max being passed as one of the query arguments works fine if we want to ensure the image is inside the defined dimensions.
If this works fine, not sure if ✨ Implement image resizing to save space Needs review makes sense any more.
The (\d*|\d*\/\d*) was not really capturing the whole house numbers that contain slash, reversing the order to get that as well: (\d*\/\d+|\d+).
When adding the problematic address to the test, I saw that the or fix (|| > |) actually broke that (seems like the broken syntax was producing correct results for this case). But then I wasn't sure if we should try to solve it with a different regex, so I just added another if block.
I also added some trimming for the street and expanded the test cases quite a bit.
Attaching patch version for composer.
Patch for composer projects.
I am not sure about the test here. /antibot needs to be requested via POST, to not get the cached page, but I did just expand the existing Functional test.
Addressed.
One note, Combine all items into a single document must be checked in the provider config, for this to work.
Created an initial MR.
As proposed by @Berdir, a the MultipleCheckoutInterface is added.
To be able to test this, go to admin/tmgmt/sources, from Target language select Multiple, check the languages and then Request translations. Submit to provider. And then, if the provider implements that interface, multiple jobs will be passed to the provider via JobCheckoutManager::requestTranslationMultiple.
There is a MR for GlobalLink that implements that, which is WIP ✨ Send multiple jobs in a single batch Active
Moved the logic and .... after some struggle ... extended the test.
Thx for the review. Addressed both comments.
Pushed first to fork 3.x :S Ignore that one, ... first day after holidays.
I went with the second suggestion from @Berdir
I added a test, but didn't run it locally (because of some issue with running phpunit tests). Let's see how it goes.
Thanks for the patch. I tested it and it works.
That being said, I am not sure if there is a better place to fix that. I was checking \Drupal\content_workflow_bynder\MigrationDefinitionCreator::buildMigrationDefinition but that's probably not enough.
Still setting to RTBC, then let's see what @Berdir says.
This needed a rebase for me.
The ::submitForm() fails seems to be unrelated, but minor, so I fixed them here. The missing 'derivative' key one is related to this issue but it happens on non-image assets, so I just added an isset().
Thanks for the MR and work. I tested the patch and added two comments.
From my perspective, same field name is completely fine. Maybe others have different opinions :)
That is an implementation of hook_form_BASE_FORM_ID_alter for media library \Drupal\media_library\Form\AddFormBase::getBaseFormId. When you choose the Dropzonejs widget you basically choose a different form, which has its own unique form id.
Or am I missing somthing?
If the solution you found works for you, than I think that's the best you can do.
Seems it's something we forgot to update after renaming some config fields.
Changing the logo.
Rerolled the patch and added fix for a similar issue in GoogleAnalyticsMigrator. Haven't checked the issue from #5.
Updated.
I rebased. There is one more thing that @Berdir noticed: perimeter_honeypot_reject() needs to use the service instead of the class.
Smaller update
Closing because it's a duplicate of 🐛 Exception when trying to clone an instance of TypeError Needs review
Updating as per #4
Quick fix by doing the same as for other classes.
That was on 10.2.0-beta1 IIRC.
After discussing with @Berdir, this could also be an option: that is to provide a way to override the value.
Interdiff is against #9
Adding an option to truncate value length (not sure about the naming). If a profile uses separate fields for let's say name and surname, this can result in quite long first names and last names.
Something like this then?
Oh snap, this was already fixed in {#3396668}. Was working on alpha version so I noticed just now when I created the patch :) closing.
That is clearly the wrong patch :) sry
Not sure if I am missing something obvious. Also not sure if this is the correct approach.
Fixing data structure issue.
Initial patch.
Added.
I just added an additional request to \Drupal\tmgmt_acclaro\Plugin\tmgmt\Translator\AcclaroTranslator::createOrder. Seems to work fine.
Initial patch.
Forgot to revert the service.yml change.