Call to a member function transformDimensions() on null in template_preprocess

Moving back to NW for the tags

Was tagged for tests in #27
Tagged for IS update in #39

#40 does not apply to 10.1.0.
Here is a reroll.

#12 seems to be the trick for me.

Ongoing issues should be set to target 11.x

#45 is necessary for 10.1.x; #40 doesn't work with it.

Patch #45 worked on Drupal 10.1.6

Conflict with other issue:

After running patch #45, I got this error, ONLY after cache clear
Deprecated function: pathinfo(): Passing null to parameter #1 ($path) of type string is deprecated in Drupal\image\Entity\ImageStyle->supportsUri() (line 385 of core/modules/image/src/Entity/ImageStyle.php).

This error is addressed in this issue, and there is a patch
Deprecated function: pathinfo() on template_preprocess_image_style
https://www.drupal.org/project/drupal/issues/3306131 🐛 Deprecated function: pathinfo() on template_preprocess_image_style Needs work
There is a patch:
https://git.drupalcode.org/project/drupal/-/merge_requests/2680.patch

It just changes one line of code, and adds a saftely check.
I added this into this patch here

- if ($style->supportsUri($variables['uri'])) {
+ if (isset($variables['uri']) && $style->supportsUri($variables['uri'])) {

#45 worked for me. I could not get #50 to apply.

#45 applies on D10.2.4

Yes, I've been using #45 on 10.2 successfully.

#50 applies on D10.2.4 and created merge request for the Patch

pameeela → changed the visibility of the branch 2957368-call-to-a to hidden.

Re-rolled patch for drupal 10.3.2

Merge requests need to target 11.x.

Please update the merge request instead of uploading new patches. That way the issue can advance.

#61 works perfectly on 10.3.2, thanks.

Some points made before are still not addressed in the latest patches (like tests) so a re-roll only won't make it. Also we maybe need thoughts of project maintainers if this issue is outdated or still required, since it had its most momentum in the Drupal 8 migration live cycle to prevent wasted efforts and resource of contributors.

Additionally: #57 and below ✨ Call to a member function transformDimensions() on null in template_preprocess Needs work are these tags added in cooperation with the project maintainers or Drupal events and are these still required? Since there was no comment added to the tags they fade a little bit into curiosity.

I know a reroll isn't all that's needed, and that's why I left the status Needs Work.

Usually NR is rather used to review patches, but it also creates attention. The situation needs some more reviews and opinions like explained in #65. Repeating posted patches triggered by Needs Work just flood the issue but do not bring us closer to a final route to go. Usually this state would require Postponed (maintainer needs more info) ("PMNMI") but since I am not the maintainer of the image framework I would leave it up to the maintainers to choose this Status. There is sadly no Status in between these both.

Further Descriptions of the Priority → and Status → values can be found in the Drupal project issues → documentation.

This crash caused me a major headache today when a new content type went live on our production system. Our editor tried to import pages from the stage system; they imported successfully but crashed when he tried to open them to edit.

Turned out that the image field in the content type had been configured without a preview image style selected, and was defaulting to "thumbnail", which doesn't exist, and was then causing this crash.

This raises two questions for me:

Firstly, why does the image style default to a style that doesn't exist? If the style doesn't exist, don't use it as a default.

And secondly, why is a crash like this allowed to persist in core? It's a relatively easy crash to make happen, and easy to fix (the patch is already done ages ago), and the crash message itself doesn't include the key detail of what image style is causing the problem, which makes it much harder to diagnose.

Please can this patch get reviewed and pushed into the next release. Thank you. :)

This worked for me!

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Please make any changes to the merge request rather than submitting new patches. Thanks.

I have been bumping into this issue from time to time, and then I come here to grab the latest patch for the current Drupal version.

I also think some simpler patches / fixes shouldn't need to take 8 years and 4 major Drupal versions to get applied, regardless if there are specific tests developed.

We will commit a validation to know if the URI is set.

Needs review

Before we review can steps be added to reproduce this?

Based on the summary and the error this seems more like a bug then a feature request.

I agree with #77 that we need steps to reproduce so anybody who knows basic site building or greater can reproduce and test the issue.

#16 delivers a set of steps to reproduce:

Received this error when creating new custom content with an image field.
At the "Manage form display" of the content entity, in the Image field settings, the "Preview image style" was set to "no preview".
Selecting there a predefined image style, e.g. "Thumbnail 100x100" solved the issue for me.
The error disappeared and the edit form of the content type was properly shown.

How does this sound?:

1. Install Drupal 11 using the standard profile and the default theme.
2. Add an image field to the Basic page content type.
3. At the "Manage form display" of the content entity, in the Image field settings, set the "Preview image style" to "no preview".

#61 still applies to 10.3.10. Thanks!