Move button--small class for add more field widget button to WidgetBase

Created on 24 June 2022, almost 3 years ago
Updated 19 July 2023, almost 2 years ago

Problem/Motivation

See #3281151: Remove extra margin on 'add paragraph' button on claro โ†’ , the class is added to the button element, if modules like paragraphs are doing something arguably weird, button might not actually be a button.

It would IMHO be better if \Drupal\Core\Field\WidgetBase::formMultipleElements() would already set that button class instead of claro adding it itself, then other themes don't have to duplicate that.

Possible problems:

* Is it an API change to move a class like that? Nothing will change for any widget that does not replace the button, but for widgets that do, it will change back to a large button.
* If and how it will affect seven

Steps to reproduce

Proposed resolution

Remaining tasks

* Create the patch to move that class from claro_preprocess_field_multiple_value_form() to the widget
* Create screenshots for seven for a regular multi-value widget

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

RTBC

Version

11.0 ๐Ÿ”ฅ

Component
Claroย  โ†’

Last updated about 19 hours ago

Created by

๐Ÿ‡จ๐Ÿ‡ญSwitzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024