28:49 28:31 Running- last update
almost 2 years ago 30,341 pass - ๐จ๐ญSwitzerland berdir Switzerland
Random test fail again I think.
- last update
almost 2 years ago 30,341 pass - last update
almost 2 years ago 30,341 pass - last update
over 1 year ago 30,341 pass 31:12 28:01 Running- Status changed to Needs work
over 1 year ago 8:31am 29 July 2023 - ๐ซ๐ฎFinland lauriii Finland
+++ b/core/lib/Drupal/Core/Field/WidgetBase.php @@ -262,7 +262,7 @@ protected function formMultipleElements(FieldItemListInterface $items, array &$f + '#attributes' => ['class' => ['field-add-more-submit', 'button--small']],
I think we could use the
#button_type
render array key instead. With that this would be just a render array change which is acceptable in a minor. - last update
over 1 year ago 29,946 pass - last update
over 1 year ago 30,424 pass, 2 fail - ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- Status changed to Needs review
over 1 year ago 9:43am 15 December 2023 - ๐ฎ๐ณIndia prashant.c Dharamshala
Added
'#button_type' => 'small'
, kept the attributes'#attributes' => ['class' => ['field-add-more-submit']],
Raised a MR, changes needs to be reviewed.
Thanks!
- Status changed to Needs work
over 1 year ago 1:26pm 15 December 2023 - ๐บ๐ธUnited States smustgrave
Seems the change at line 281 is out of scope. And issue summary mentions screenshots of a multi value widget which should be added to the user interface section of the summary
- ๐จ๐ญSwitzerland berdir Switzerland
There is no change in core *if* you use Claro, we just move the class. Other themes that currently don't override it like that might change though. I suppose we could compare the backend with another theme, but not even sure which one?
- Status changed to Needs review
about 2 months ago 10:59pm 28 February 2025 - ๐จ๐ญSwitzerland berdir Switzerland
Removing seven as I think that's no longer a concern. Gin extends from claro, so it inherits this, so nothing should change there either.
- ๐บ๐ธUnited States smustgrave
Hiding old patches.
Tested by adding an unlimited text field to a random content type. The "Add another item" button remained unchanged by the MR so no regression.
- First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.