7:36 7:18 Running- last update
11 months ago 30,341 pass - last update
11 months ago 30,341 pass - last update
11 months ago 30,341 pass - last update
11 months ago 30,341 pass 9:59 6:48 Running- Status changed to Needs work
11 months ago 8:31am 29 July 2023 - 🇫🇮Finland lauriii Finland
+++ b/core/lib/Drupal/Core/Field/WidgetBase.php @@ -262,7 +262,7 @@ protected function formMultipleElements(FieldItemListInterface $items, array &$f + '#attributes' => ['class' => ['field-add-more-submit', 'button--small']],I think we could use the
#button_typerender array key instead. With that this would be just a render array change which is acceptable in a minor. - last update
11 months ago 29,946 pass - last update
8 months ago 30,424 pass, 2 fail - 🇮🇳India Prashant.c Dharamshala
Prashant.c → made their first commit to this issue’s fork.
- Status changed to Needs review
7 months ago 9:43am 15 December 2023 - 🇮🇳India Prashant.c Dharamshala
Added
'#button_type' => 'small', kept the attributes'#attributes' => ['class' => ['field-add-more-submit']],Raised a MR, changes needs to be reviewed.
Thanks!
- Status changed to Needs work
7 months ago 1:26pm 15 December 2023 - 🇺🇸United States smustgrave
Seems the change at line 281 is out of scope. And issue summary mentions screenshots of a multi value widget which should be added to the user interface section of the summary
- 🇨🇭Switzerland Berdir Switzerland
There is no change in core *if* you use Claro, we just move the class. Other themes that currently don't override it like that might change though. I suppose we could compare the backend with another theme, but not even sure which one?