- Issue created by @primsi
- 🇸🇮Slovenia primsi
If this works fine, not sure if ✨ Implement image resizing to save space Needs review makes sense any more.
- 🇨🇭Switzerland berdir Switzerland
No, it does not. But lets test this a bit, specifically with different aspect images of original images. The UI always calculates the other value from the one you change dynamically. We likely need to do this as well to get a valid size based on the original aspect ratio? we do not want to change that.
Do we have the width/height of the original image in the metadata?
I wrote this for the image_resize project: https://git.drupalcode.org/project/image_resize/-/blob/1.x/src/SizeCalcu...
we'll need to decide and define if the sizes you configure are upper or lower bound, meaning if it should be at least as big or not bigger than.
If the API handles that then great and this is fine.
- 🇸🇮Slovenia primsi
Seems like
fit=max
being passed as one of the query arguments works fine if we want to ensure the image is inside the defined dimensions. Automatically closed - issue fixed for 2 weeks with no activity.