- Merge request !11Issue #3307402: Use interfaces in content lock service → (Merged) created by pookmish
- 🇺🇸United States edmund.dunn Olympia, WA
Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC
- 🇳🇱Netherlands e.ruiter
Thanks for the patch
The time service in the Contentlock class should be added to make the patch complete:
/** * The time service. * * @var \Drupal\Component\Datetime\TimeInterface $time */ protected $time;
- last update
over 1 year ago 13 pass - 🇦🇺Australia acbramley
Given these changes touch a lot of files it'd be great to get them in to avoid any nasty rerolls.
- last update
10 months ago 13 pass - 🇧🇪Belgium LRoels Ghent
+1 : Lets get this merged!
Following the comment in #12, here is a new static version of this patch.
- First commit to issue fork.
-
alexpott →
committed 42bfb4d2 on 8.x-2.x authored by
pookmish →
Issue #3307402 by pookmish, vanilla-bear, alexpott, DieterHolvoet,...
-
alexpott →
committed 42bfb4d2 on 8.x-2.x authored by
pookmish →
- Status changed to Fixed
8 months ago 11:47pm 19 March 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Fixed up the MR to adhere to coding standards.
I'm not 100% convinced that everything needs an interface - like a swappable content lock service sounds like a nightmare to me and even supporting decoration is interesting. But my concerns are minor put against the fact the module is incompatible with modules that decorate well known core services.
Automatically closed - issue fixed for 2 weeks with no activity.