I could not find any reason why the sidebar icon has been changed? To my eye that looks odd. Can I get some arguments why this has been done?
https://git.drupalcode.org/project/gin/-/merge_requests/420/diffs#6b572a...
Hi,
Here is fresh version of the patch against 8.x-2.0-alpha5. I think I had marked the patch against the wrong branch.
This patch was my first attempt to address the issue.
Nice work! Tested this with D10.1 and with 2.0.0-alpha3, no more console log error!
I tested this patch with vanilla D10.1 this seems works as Tuuuukka reported. In some setups the diff.plugin.yml config changes are exported only after saving the /admin/config/content/diff/fields form but I guess this is the way the diff configs are updated / detected. After saving the settings form the patch works as expected.
I ran these these with PHP 8.1.22 & vanilla D10.1.5 and they are working fine!