- Issue created by @maddentim
- πΊπΈUnited States maddentim
I tried updating typed_data to 2.1.0 and switching out the use statement in src/SocialShareLinkManager.php to be the Drupal\Core\Plugin\Discovery\AnnotatedClassDiscovery. This fixed the fatal error, but the social share buttons are not rendering. I am not sure if it is a database issue and when I have more time I will try refreshing the database from production and seeing if it works again. It might be a few days though.
- Merge request !5Issue #3461912: Fatal error on upgrade of typed_data dependencies β (Merged) created by volkerk
- Status changed to Needs review
4 months ago 1:05pm 1 August 2024 - Status changed to RTBC
3 months ago 8:50am 12 August 2024 - π©πͺGermany daniel.bosen
lgtm and fixes our projects. We need to remember to close π [error] Error: Class "Drupal\Core\Plugin\ContextAwarePluginBase" not found in include() (line 44 of modules/contrib/social_share/src/Plugin/SocialShareLink/LInkedInShareLink.php) Needs review as well, once this is merged.
- πΊπΈUnited States maddentim
Do we still need the type_data dependency in social_share.info.yml after this change?
type: module name: Social Share description: 'Contextually configurable social share buttons.' package: Social media core_version_requirement: ^8 || ^9 || ^10 dependencies: - typed_data:typed_data
- First commit to issue fork.
- π¦πΉAustria fago Vienna
ad #11: yes, it's driving the replacments, see https://git.drupalcode.org/project/social-share/-/blob/8.x-2.x/src/Socia...
Thank you, merging!
-
fago β
committed df5b9012 on 8.x-2.x authored by
volkerk β
Issue #3461912 by volkerk: Fix compatibility with typed_data 2.1
-
fago β
committed df5b9012 on 8.x-2.x authored by
volkerk β
- Status changed to Fixed
about 1 month ago 4:44am 19 October 2024 Automatically closed - issue fixed for 2 weeks with no activity.