- First commit to issue fork.
- @aaronbauman opened merge request.
- πΊπΈUnited States AaronBauman Philadelphia
MR6 adds deprecation notices to the Context classes for 1.x branch.
See followup issue for 2.0.x π Remove Context classes Fixed
- Status changed to Needs review
almost 2 years ago 5:30pm 23 February 2023 - Status changed to Needs work
almost 2 years ago 9:00pm 23 February 2023 - πΊπΈUnited States tr Cascadia
Thanks. Can you fix up the @deprecated statements so they don't generate those coding standards messages?
- πΊπΈUnited States tr Cascadia
Also, don't we need a @trigger_error on the classes?
- πΊπΈUnited States AaronBauman Philadelphia
Would you want the
trigger_error
just inside the class statement? Or within each method?
I can also look into a deprecated core class and see what they did. - πΊπΈUnited States tr Cascadia
I believe the rules for how to properly deprecate classes are in the coding standards document somewhere - I haven't looked at it recently, but in the changes I made locally (back in December) for testing I put a @trigger_error between the namespace and the first use on all the deprecated classes.
- Status changed to Needs review
almost 2 years ago 4:41pm 24 February 2023 - πΊπΈUnited States AaronBauman Philadelphia
Updated annotation strings and added trigger_error()s
- πΊπΈUnited States tr Cascadia
With this, there should be a blank line between the @deprecated tag and the @see tag.
Is this the proper way to deprecate Interfaces? I looked it up last year and didn't find any information or examples in core, which is why I never did this myself. Will deprecating an Interface like the above patch actually trigger deprecation notices in code that uses a class implementing that interface? The closest I could find to deprecating an Interface was to deprecate each of the methods individually. Does this need to be done, or can we get away with doing the same thing we do with classes?
- Status changed to Fixed
almost 2 years ago 3:08am 16 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.