Make the meta sidebar interact with the toolbar menu sidebar

Yannick Bloemen → made their first commit to this issue’s fork.

Thanks for your work on this @Yannick Bloemen 🎉

I pushed some changes to set a breakpoint to 1280 and to auto hide either the toolbar or the sidebar depending what is toggled. Also added support for the new navigation.

Needs a review

verified MR!321, Now menu hide when clicked meta sidebar.

For reference:-
After MR

Moving into the RTBC +

@volkerk fixed the bug

Tested with latest chrome and firefox esr, both default vertical toolbar and experimental new core nav.

Lgtm, nice.

Merged, thanks 🚀

Automatically closed - issue fixed for 2 weeks with no activity.

I seem to have an error on smaller screens when I click the toggle button to show/hide the meta sidebar.

If I simply open a node edit form on smaller screen, like 1200px wide:

TypeError: Cannot read properties of undefined (reading 'collapseToolbar')
    at Object.showSidebar (sidebar.js?sh4cqs:39:60)
    at sidebar.js?sh4cqs:14:98
    at Array.forEach (<anonymous>)
    at Object.init (sidebar.js?sh4cqs:12:59)
    at Object.attach (sidebar.js?sh4cqs:8:29)
    at drupal.js?v=10.3.1:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=10.3.1:162:34)
    at big_pipe.js?v=10.3.1:153:10
    at big_pipe.js?v=10.3.1:184:3

If I widen my screen so its for example 1300px wide, then the error is not there.

I think it has to do with this part in sidebar.js:

      // Check which toolbar is active.
      if (window.innerWidth < breakpointLarge) {
        Drupal.ginCoreNavigation?.collapseToolbar();

        if (toolbarVariant === 'vertical') {
          Drupal.ginToolbar.collapseToolbar();
        } else if (toolbarVariant === 'new') {
          Drupal.behaviors.ginNavigation?.collapseSidebar();
        }
      }

Also, it does not work for me, when I open the meta sidebar (on the right), the (core experimental) Navigation sidebar on the left does not collapse.
- Drupal core 10.3.1
- Gin 8.x-3.x-dev / also tested on Gin 8.x-3.0-rc13
- navigation module enabled
- navigation_top_bar module enabled

Is that just me and my setup for some reason ?