Deprecate and remove the AJAX replace method

Tom Konda → made their first commit to this issue’s fork.

I changed existing 'method' => 'replace' to 'method' => 'replaceWith' in test modules.
But core/lib/Drupal/Core/Render/Element/RenderElement.php has conflict, so need to resolve.

Binoli Lalani → made their first commit to this issue’s fork.

Binoli Lalani → changed the visibility of the branch 3303557-deprecate-and-remove to hidden.

Hello,

I have tried to resolve the conflicts of 5384 MR but It has unwanted code changes so I hide that MR and created a new MR. Please review it.

Thank You!

Discussed with @smustgrave in slack, we should add a deprecation in 10.3.0 - can be in a separate MR against 10.3.x since the 11.x one seems fine.

Hello @catch,

Thank you for reviewing the MR. I have created another MR against 10.3.x branch and added deprecation.
Pipeline is failed due to phpstan error in system.module. I verified that it is not related to this code change. It is already there in the latest code.

Please review the MR and let me know if any changes needed.

Thank you!

This looks fine. The 10.3.x phpstan fail is indeed in HEAD and should go away when fixed, although will need to rerun the pipeline or rebase to get a full test run.

10.3 appearing green now, deprecation looks good.

Committed 5533984 and pushed to 11.x. Thanks!

nod_ → closed merge request !7364

nod_ → closed merge request !7388

Automatically closed - issue fixed for 2 weeks with no activity.

This issue came up in Slack: https://drupal.slack.com/archives/C03L6441E1W/p1716058078575899 and https://drupal.slack.com/archives/C03L6441E1W/p1716060358368069. IIUC, the pathauto module was still using 'method' => 'replace', at least once.

I think we should have a change record for this issue, so I am reopening it and adding the issue tag.

A change record will be helpful because I've identified that more modules could be affected:

search_api
panels
search_api_solr
pathauto
facets
search_api_attachments
diff
password_policy
shield

I added the draft change record (CR) https://www.drupal.org/node/3450770 → . I am moving this issue to NR for that.

If the CR looks good, then we can publish it and return this issue to Fixed.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The change record looks good. The only comment I thought about making is that because replaceWith is the default method (as defined in Drupal.Ajax) it would also be possible to just remove the command altogether from the array. But I don't think that's as clear/easy to explain in a CR as using replaceWith explicitly.

Is it worth making a follow-up MR to reference the change record, not this issue, in the deprecation message?

@benjifisher yes that wouldn't hurt.

benjifisher → changed the visibility of the branch 3303557-reference-change-record to hidden.

Back to NR for https://git.drupalcode.org/project/drupal/-/merge_requests/8250

The deprecated code is already removed in the 11.x branch, so this follow-up is needed on the 10.3.x branch only.

benjifisher → changed the visibility of the branch 10.3.x to hidden.

CR reads fine. Before/after examples are perfect.

Committed/pushed to 10.4.x and cherry-picked to 10.3.x, thanks!

catch → closed merge request !8250

Automatically closed - issue fixed for 2 weeks with no activity.

So many modules... Can this change be added to the automated D11 compatibility bot?

quietone → closed merge request !5384