LGFM ++
'@start -- ' . $this->t('the initial record number in the set'),
'@end -- ' . $this->t('the last record number in the set'),
'@total -- ' . $this->t('the total records in the set'),
'@label -- ' . $this->t('the human-readable name of the view'),
'@per_page -- ' . $this->t('the number of items per page'),
'@current_page -- ' . $this->t('the current page number'),
'@current_record_count -- ' . $this->t('the current page record count'),
'@page_count -- ' . $this->t('the total page count'),
@prem-suthar RTBC +1
@shalini_jha
RTBC++
We may consider updating the documentation for the \Drupal\Core\Logger\LoggerChannelInterface interface
to include practical examples of how to use $context, including the addition of operation links.
This would ensure that the functionality is more accessible and understandable to everyone using the logging system.
JavaScript tests can be a bit unpredictable.
The code changes in core/lib/Drupal/Core/Render/theme.api.php should not directly affect these tests, I am investigating to better understand the issue.
For the data deletion cron hook, we need to implement a configuration that allows administrators to define the desired time period for deletion.
This should be added as an option in the module configuration interface to ensure flexibility and meet different website needs.
Tks
Patch successfully applied and updated text
#title , #description
RTBC+1
The content with the topics seems good to me.
RTBC +1
PROJECT, INSTALLATION, INSTRUCTIONS TO ENABLE HTML, OVERVIEW, FEATURES, REQUIREMENTS, CREDITS
Patch #26 RTBC +1
@Spokje LGTM on remove:
RTBC +1
RTL LGTM
LGTM.
The #4 patch applies cleanly and works as expected.
LGTM.
The #8 patch applies cleanly and works as expected.
LGTM.
LGTM.
The #2 patch applies cleanly.
$request_time = $this->container->get('datetime.time')->getCurrentTime();
looks god to me.
The #3 patch applies cleanly and works as expected.
LGTM.
The #5 patch applies cleanly and works as expected.
looks good to me!
LGTM moving to RTBC.
RTBC +1
+1 RTBC
+1 RTBC
Looks good to me #3 @Jay Jangid ...
RTBC+1
Looks good to me #4 @Sonalmg ...
RTBC+1
Looks good to me @immanojraj ...
Looks good to me, thanks!
RTBC +1
The patch #2 looks good!
+1 RTBC
@Manoj looks good to me RTBC+1.
* Introduction (ok)
* Requirements (ok)
* Recommended modules (ok)
* Installation (ok)
* Configuration (ok)
* Troubleshooting (ok)
* FAQ (ok)
* Maintainers (ok)
Look good to me.