- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:08am 19 January 2023 - Status changed to RTBC
over 1 year ago 1:42pm 31 July 2023 Verified the MR1, the readme.md file is added as per standard. Added screenshots for reference, RTBC++
- Status changed to Needs work
over 1 year ago 2:16pm 8 August 2023 - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 2:48pm 8 August 2023 - Status changed to Needs work
over 1 year ago 1:17am 5 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi elber,
I applied and reviewed your MR and confirmed that README.md is now present and following the README.md template. But you need to add a space after the period in the "Project name and introduction" section specifically the "Adds" after the period. This is the description sentence of the issue " added a product to his cart.Adds an "add to cart confirmation" view mode"
Please look at the screenshot I attached for your reference
Thank you
- Status changed to Needs review
over 1 year ago 11:04am 5 September 2023 - ๐ง๐ทBrazil elber Brazil
Hi kenyoOwen I added a period, is it good? Please revise
- Status changed to RTBC
over 1 year ago 11:01am 12 September 2023 - ๐ฎ๐ณIndia Arshu1864
Hi elber,
I applied and reviewed your MR and confirmed that README.md is now present and following the README.md template. I have made the follwing steps while testing:
- I have first clone the module in my locally.
- Then I download the patch from the merge request.
- Applied the patch on the module and check the file structure.
- The readme.md file was present in the folder structure.
- Opened the Readme.md filea and check whether all the spacing is properly done.
- Everything ws fine and all the informatin was present in the file.
Everything looks very well. No issue noticed from my end.
- Status changed to Needs work
over 1 year ago 1:54pm 12 September 2023 - ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
over 1 year ago 5:33am 14 September 2023 - Status changed to RTBC
over 1 year ago 11:45am 15 September 2023 - ๐ง๐ทBrazil elber Brazil
Hi I reviewed the last changes. ( I just fixed the characters limit in one line)
It is good to me, Readme file is clear explaning the module.
Also following drupal standards.
The errors mentioned by Apaderno has been fixed in my opinion.
Moving to RTBC.
- First commit to issue fork.
-
TomTech โ
committed 272ff31b on 1.x authored by
elber โ
Issue #3333146: Missing README.md file
-
TomTech โ
committed 272ff31b on 1.x authored by
elber โ
- Status changed to Fixed
about 1 year ago 9:59pm 2 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.