Account created on 7 September 2021, about 3 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

Hi elber,

I applied and reviewed your MR and confirmed that README.md is now present and following the README.md template. I have made the follwing steps while testing:

  1. I have first clone the module in my locally.
  2. Then I download the patch from the merge request.
  3. Applied the patch on the module and check the file structure.
  4. The readme.md file was present in the folder structure.
  5. Opened the Readme.md filea and check whether all the spacing is properly done.
  6. Everything ws fine and all the informatin was present in the file.

Everything looks very well. No issue noticed from my end.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

Arshu1864 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have reviewed the patch and it is working finre the module is succesfully installed on drupal 10 working perfectly fine. I have done the following steps to tet the patch:

  1. Install drupal 10 fresh.
  2. Clone the module.
  3. Use wgwt to download the patch.
  4. Use git apply-index and patch file to apply the patch.
  5. Install the patch and check whether it is working fine or not and whether this patch is creating some issue or not.
๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have created a merge request and changed the code please review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

Arshu1864 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have fixed some of the coding standard issue on the module and created merge request for it but some dependecies need to be resolved from the core.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

The issue has been resolved the theme is now compatible with drupal 10 please test it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have tested the theme and the menus are working fine on mobile and desktop devices. I have done the following steps to test this issue:

  1. Install the latest version of drupal 9.
  2. Install the theme using composer.
  3. Then I observe the issues carefully.
  4. After observing the issue I pulled the merge request from the git.
  5. I see and tested the changes done after the merge request was pulled.
  6. The menu was working fine after I pulled the code from merge request.

Now when the issue is fixed it can pushed to RTBC

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

Sorry the while creating patch file the # got added I had renamed the file and added along with this comment

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have cloned from the 8.x-1.x branch and my npm version is 9.6.4 and node version is v16.19.1

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have fixed the issue and tested it now it is working fine. There is on npm audit there is showing found 0 vulnerabilities. I am attaching patch alongside with it please check.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I'm fixing the issue and will hopefully be resolved by end of this week

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I take full responsibility of solving this issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have applied the patch now the theme is compatible with druapl 10. Please test it

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I want to be the maintaniner of this theme and I will take full responsibility of mainataining this theme on regular basis

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have migrated the theme to drupal 10 and its subtheme also please test it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

Arshu1864 โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Arshu1864

I have Fixed the issue change the core version requirement from ^9.5 to ^9.
Summiting a patch please review.

Production build 0.71.5 2024