Fix PHPStan and Coding standards issues

130/130 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ------------------------------------------------------------------------------ Line src/Controller/BackupController.php ------ ------------------------------------------------------------------------------ 28 \Drupal calls should be avoided in classes, use dependency injection instead 115 \Drupal calls should be avoided in classes, use dependency injection instead 116 \Drupal calls should be avoided in classes, use dependency injection instead 133 \Drupal calls should be avoided in classes, use dependency injection instead 134 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Controller/ScheduleListBuilder.php ------ ------------------------------------------------------------------------------ 44 \Drupal calls should be avoided in classes, use dependency injection instead 46 \Drupal calls should be avoided in classes, use dependency injection instead 47 \Drupal calls should be avoided in classes, use dependency injection instead 55 \Drupal calls should be avoided in classes, use dependency injection instead 57 \Drupal calls should be avoided in classes, use dependency injection instead 73 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Core/Destination/DirectoryDestination.php ------ ------------------------------------------------------------------------------ 241 \Drupal calls should be avoided in classes, use dependency injection instead 246 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Core/Filter/CompressionFilter.php ------ ------------------------------------------------------------------------------ 204 \Drupal calls should be avoided in classes, use dependency injection instead 257 \Drupal calls should be avoided in classes, use dependency injection instead 305 \Drupal calls should be avoided in classes, use dependency injection instead 307 \Drupal calls should be avoided in classes, use dependency injection instead 312 \Drupal calls should be avoided in classes, use dependency injection instead 330 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Core/Filter/FileNamer.php ------ ------------------------------------------------------------------------------ 24 \Drupal calls should be avoided in classes, use dependency injection instead 98 \Drupal calls should be avoided in classes, use dependency injection instead 99 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Core/Filter/Notify.php ------ ------------------------------------------------------------------------------ 45 \Drupal calls should be avoided in classes, use dependency injection instead 58 \Drupal calls should be avoided in classes, use dependency injection instead 102 \Drupal calls should be avoided in classes, use dependency injection instead 114 \Drupal calls should be avoided in classes, use dependency injection instead 139 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Core/Service/Mailer.php ------ ------------------------------------------------------------------------------ 30 \Drupal calls should be avoided in classes, use dependency injection instead 31 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Core/Source/MySQLiSource.php ------ ------------------------------------------------------------------------------ 48 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Drupal/Destination/DrupalBrowserUploadDestination.php ------ ------------------------------------------------------------------------------ 22 \Drupal calls should be avoided in classes, use dependency injection instead 57 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Drupal/Destination/DrupalDirectoryDestination.php ------ ------------------------------------------------------------------------------ 35 \Drupal calls should be avoided in classes, use dependency injection instead 62 \Drupal calls should be avoided in classes, use dependency injection instead 72 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Drupal/Environment/DrupalSetMessageLogger.php ------ ------------------------------------------------------------------------------ 43 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ----------------------------------------------------------------------------------------- Line src/Drupal/Filter/DrupalEncrypt.php ------ ----------------------------------------------------------------------------------------- 48 \Drupal calls should be avoided in classes, use dependency injection instead 74 \Drupal calls should be avoided in classes, use dependency injection instead 75 \Drupal calls should be avoided in classes, use dependency injection instead 78 Call to static method encryptFileWithPassword() on an unknown class Defuse\Crypto\File. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 79 \Drupal calls should be avoided in classes, use dependency injection instead 83 Caught class Drupal\backup_migrate\Drupal\Filter\Exception not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 92 \Drupal calls should be avoided in classes, use dependency injection instead 93 \Drupal calls should be avoided in classes, use dependency injection instead 96 Call to static method decryptFileWithPassword() on an unknown class Defuse\Crypto\File. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 100 Caught class Drupal\backup_migrate\Drupal\Filter\Exception not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ ----------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Drupal/Filter/DrupalUtils.php ------ ------------------------------------------------------------------------------ 75 \Drupal calls should be avoided in classes, use dependency injection instead 76 \Drupal calls should be avoided in classes, use dependency injection instead 87 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Drupal/Source/DrupalSiteArchiveSource.php ------ ------------------------------------------------------------------------------ 91 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/BackupMigrateAdvancedBackupForm.php ------ ------------------------------------------------------------------------------ 45 \Drupal calls should be avoided in classes, use dependency injection instead 48 \Drupal calls should be avoided in classes, use dependency injection instead 75 \Drupal calls should be avoided in classes, use dependency injection instead 96 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/EntityDeleteForm.php ------ ------------------------------------------------------------------------------ 43 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/ScheduleDeleteForm.php ------ ------------------------------------------------------------------------------ 41 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/ScheduleForm.php ------ ------------------------------------------------------------------------------ 134 \Drupal calls should be avoided in classes, use dependency injection instead 140 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/SettingsProfileDeleteForm.php ------ ------------------------------------------------------------------------------ 41 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/SettingsProfileForm.php ------ ------------------------------------------------------------------------------ 63 \Drupal calls should be avoided in classes, use dependency injection instead 69 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/WrapperEntityForm.php ------ ------------------------------------------------------------------------------ 88 \Drupal calls should be avoided in classes, use dependency injection instead 95 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ [ERROR] Found 63 errors

Comments & Activities

Issue created by @Akshay kashyap
Assigned to Arshu1864
Comment over 1 year ago →
🇮🇳India Arshu1864
Status changed to Active over 1 year ago10:23am 1 May 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Since there are no patches nor MRs, the status is still Active.
Comment over 1 year ago →
🇺🇸United States DamienMcKenna NH, USA
Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.0 & MySQL 5.7
last update over 1 year ago
Not currently mergeable.
@arshu1864 opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.0 & MySQL 5.7
last update over 1 year ago
7 pass, 4 fail
Issue was unassigned.
Status changed to Needs work over 1 year ago9:27am 3 May 2023
Comment over 1 year ago →
🇮🇳India Arshu1864
I have fixed some of the coding standard issue on the module and created merge request for it but some dependecies need to be resolved from the core.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.0 & MySQL 5.7
last update over 1 year ago
7 pass, 4 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
7 pass, 4 fail
Comment 3 months ago →
🇩🇪Germany Grevil
Through 📌 Automated Drupal 11 compatibility fixes for backup_migrate Needs work , we wanted to introduce hard failure, if PHPStan fails.

Seeing, that there are this many PHPStan issues, it doesn't make sense to fix all of them inside the Drupal 11 issue.

Hence, after the Drupal 11 release lands, we should disallow phpstan failure in the .gitlab-ci.yml again and fix all PHPStan (and PHPCS issues).

Adjusted the Issue summary.

Let's wait for 📌 Automated Drupal 11 compatibility fixes for backup_migrate Needs work to get fixed. After that, this issue can be tackled!
Comment 3 months ago →
🇩🇪Germany Grevil
Comment 3 months ago →
🇩🇪Germany Grevil

Fix PHPStan and Coding standards issues

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities