- Issue created by @donquixote
- Status changed to Needs work
about 1 year ago 6:01am 9 October 2023 - First commit to issue fork.
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @elber opened merge request.
- Assigned to elber
- last update
about 1 year ago 23 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:16pm 9 October 2023 - Merge request !39Issue #3387046 by rajdip_755, Tirupati_Singh, elber : Resolve the incorrectly described $rendering_object parameter issue. → (Open) created by rajdip_755
- last update
about 1 year ago 23 pass - Status changed to Needs work
5 months ago 6:37am 6 August 2024 - 🇮🇳India Tirupati_Singh
Hi, I've applied both the
MR !39
andMR !38
as patches and got error while applying the patches. I think it has occurred due to the presence of merge conflicts on both the MRs. I've reviewed both the MRs and found that theMR !38
only changes the doc comments@param type
for only 3 files and theMR !39
has updated both doc comments and parameter name as per the@param type
for all the file wherever it has been used. I think MR! 39 has the appropriate changes for the raised issue and MR !38 has only few changes, so MR !38 can be closed for now.
I've tested the changes made on MR !39 by checking out the3387046-revise-rendering-object
branch and the module functionlality is working fine. Got no errors while using the module. I've attached the screenshots for reference.As there's merge error/conflicts present for MR !38 and few changes still required, hence changing the issue status to Needs work.
- Status changed to Needs review
5 months ago 10:22am 6 August 2024 - 🇮🇳India rajdip_755 kolkata
Thanks @Tirupati_Singh for reviewing the MR.
I've updated the MR as per the changes requested. Please review the updated MR.
- Status changed to RTBC
5 months ago 10:54am 6 August 2024 - 🇮🇳India Tirupati_Singh
I've tested the changes made on MR !39 and can confirm that the issue has been resolved successfully. I'm attaching the screenshots for reference. Hence moving the status to RTBC.