🇮🇳India @rajdip_755

Hi @alvarodemendoza, I think maxlength module is working for the character count only, but here @rviner is asking for the word count.
I'm attaching here two issue links on which CKEditor5 word counter feature is under developement.
1. https://www.drupal.org/project/ckwordcount/issues/3276563 🌱 [Meta] Create new major branch and add support for CKEditor 5 Active (CKEditor Wordcount)
2. https://www.drupal.org/project/textfield_counter/issues/3440466 ✨ Implement Word Count Feature for text, textarea and CKEditor 5 in textfield_counter Module RTBC (Textfield Counter)

Hi all, I've reviewed the patch attached in #14 and #13.

After applying the patch #14 the login history view is not working due to the missing/broken handler error as there is no changes in the views.view.login_history.yml file, so we can conclude that this patch is incompatible to provide the solutions for this feature request.

For the patch #13, it working fine for me, and the failed login are listed successfully for me. But there are some pointers I want to mention for this patch.

• I think it will be better if we can change the label of Event Type to "Login Type".
• If the users are trying to login with the correct email ID and failed to login due to the wrong password, then it's should be marked and
  listed as failed login but currently it's not happening as the logic is implemented just for the user name in case of failed login listing ( implemented in the function _login_history_form_user_login_validate() ).

Attached here the screenshot of the login history view page below.

I'm moving this issue to Needs Work state. Please share your thoughts as well on the pointers I mentioned for the patch #13.

Thanks !

Hi all,

I have successfully replicated the issue and for solving it, applied the patch attached in #14 .

This patch is successfully fixed the QR code generation issue. I'm attaching here the screenshots of the config form before and after applying the patch respectively.

Along with that, I've converted the patch as MR also.

Thanks !

rajdip_755 → changed the visibility of the branch 3416397-qr-code-is to hidden.

Hi @scott_euser, I’ve applied MR !182 as a patch.

The UI changes are reflecting perfectly as expected in the issue description; I’m attaching screenshots for both the Gin and Claro themes.

@borisson_ I’ve also reviewed the code changes. Here are some key points regarding the MR:

1. This MR addresses the following issue 🐛 Clicking on + icon makes the page scroll to the top Fixed and resolved successfully.
2. Previously, fields with only one nested item appeared as nested fields. However, due to logic implemented in the following
   lines, these are no longer treated as nested fields. @scott_euser, you mentioned the reasoning in the doc comment, so I’ve highlighted it here for quick reference.

I’m moving this to RTBC. Thanks!

Hi @simonbaese, We have updated the codebase of the module as per your recommendations in #15. Please review the chnages.
Thanks!

Hi @girish_lnweb, I have also run the phpcs but can't replicating the issue as you mentioned in #3 .

Along with this I have checked lines mentioned by @ankitv18 in the codebase of the module and the \Drupal is used in those lines which is not good as per the Drupal Coding Standard, we should use the DI for those lines.

Thanks !

I've reviewed the changes made by @uttam that's working fine, but the return statement will not work because of the changes. So that, I update code and add the same logic inside the EntityCopyReferenceConfirm class from where the copyEntity function is called.

I'm attaching here the screenshot after the changes done.

Thanks !

Hi @manish-31, I have applied the MR !10 as a patch, it's applied successfully. And the documentation for the hooks is also looking good.

I'm moving this to RTBC.

Thanks !

Hi @uttam,

I have reviewed the MR !3 and applied the same as the patch. It's applied successfully.

Drupal version: 10.3.0
Module version: 1.0.0-beta3

After applying the patches a new permission is available to bypass the entity view redirect and the feature is working fine, attaching here the screen recording of before and after applying the patch.

I'm moving this to RTBC.

Thanks !

Hi @phenaproxima, I have applied your patch and it's applied successfully with the following setup.

project_browser version: 2.0.0-alpha2
drupal version: 11.0.1

And after applying the patch the command for installing drush is not showing anymore. I'm attaching here both the screenshots of before and after applying the patch respectively.

I'm moving it to RTBC.

Thanks !

Thanks, @pcambra, for your input on comment #2!

I faced a similar issue and found this issue thread. We're now using the purge_queuer_url module, which queues all URLs that need to be invalidated. To automatically purge the queue during cron runs, we enabled the purge_processor_cron module, which is a submodule of the purge module.

Although the purge_queuer_url module is listed as a required module in the README file, I believe it would be beneficial to mention this requirement on the project page as well.

rajdip_755 → created an issue.

Thanks @Tirupati_Singh for reviewing the MR.

I've updated the MR as per the changes requested. Please review the updated MR.

@kalash-j I have applied the updated MR as a patch in a drupal instance with 2256 numbers of users. It's working fine for me attaching below the screenshot of the installation process of the module using drush command and the UI.

Thanks !

I'm using a drupal 11 setup and try to use UserAuthenticationInterface instead of UserAuthInterface and created the following patch for the fixes. I have changed the authentication workflow little bit to use the UserAuthenticationInterface.

Please review the patch. If it's working fine we can convert it to MR.

Thanks !

Hi everyone!

I'm trying to review the MR 4 but I'm unable to reproduce the same issue mentioned in the description.

1. While I'm trying to replicate the by installing the latest version of this module(4.0.2) using the composer then getting a different issue. The screenshot of the issue attached herewith
2. But, if we are trying to replicate by cloning the target branch i.e 4.0.x of this project, then none of the issue is encountered.

It will be helpful if someone please mention the steps to reproduce for the issue mentioned in the description.

Thanks in advance!

rajdip_755 → made their first commit to this issue’s fork.

Hi @silvi.addweb, I have tried to applied your MR as a patch to the latest version of the module v1.7.0 . It's successfully added the revison ID in the table. But can you explain what is the need to add the following lines.

if ($revision_count > 1) {
      $build['submit'] = array(
        '#type' => 'submit',
        '#button_type' => 'primary',
        '#value' => t('Compare selected revisions'),
        '#attributes' => array(
          'class' => array(
            'diff-button',
          ),
        ),
      );
    }

For this changes the Compare selected revisions button are coming twice side by side, which is not looking good. In the latest versions of this module there is a feature to show this button at the top of the table if there are more than 5 revisions. So that I think we should not add these lines in this PR.

I'm attaching here the screenshot of the UI before and after applying the changes of the MR.

Thanks !

Hi @bgustafson, Previously I have uploaded the screenshot of the terminal after running drush secrev now I'm attaching here the screenshot of the page after running the security review from the following url /admin/reports/security-review. Still I'm not getting any executable_php error.

I think there maybe some permission related issue. For the clarification I'm attaching here the file permissions of the particular file and /sites/default/files folder.

Thanks !

Hi @uttam, I've tried to apply your MR it's successfully added the required fields.

1. The external link is not working for the registration redirection and giving the following error.Redirects to external URLs are not allowed by default, use \Drupal\Core\Routing\TrustedRedirectResponse for it.
2. The internal link is working fine for the password redirect and new registration.
3. The external link is working fine for the password redirect.
4. Please check the review comment added in MR.

Please do the needful changes accordingly, Thanks !

Hi @jennypanighetti, I think this is not the issue of this particular module. The message only shows the stable versions of drupal core. Currently there are no stable versions of drupal 10.3 or 11 So that this is not showing any versions.

This occurring due to the current functionality of the update module of the drupal core.
If you want to verify please commented out the following lines in getPossibleCoreUpdateVersions() function of the web/core/modules/update/src/ProjectCoreCompatibility.php file.

$possible_core_update_versions = array_filter($possible_core_update_versions, function ($version) {
      return VersionParser::parseStability($version) === 'stable';
    });

You can now see that the dev and rc versions will be shown in the message. I'm attaching here the screen shot after applying the above changes.

Thanks!

Hi @MahmoudSayed96, I can replicate the same issue in my local setup.
You can take create a sibling folder of webroot named drush in you project directory and create a drush.yml file inside that with the following details.

options:
  uri: '<your_site_url>'

Ref: https://drupal.stackexchange.com/questions/197651/how-i-change-my-site-u...
In this way, you can set the drush uri, which can resolved the issue. Please check this way and let me know if it's worked for you.
I'm attaching the screenshot here after following the above mentioned steps.

Hi @DYdave, I can replicate this issue. I'm working on this.
I think it will be better to replace the system_get_module_admin_tasks() as it's already marked as deprecated in drupal 10.2.0 .

Thanks @michellezeedru for reviewing the patch and suggestions.
I've raised the MR with all the changes. Please verify it.

rajdip_755 → changed the visibility of the branch 3447150- to hidden.

Please verify the patch attached herewith. Later on I'll raise the MR.

rajdip_755 → changed the visibility of the branch 3450876-default-value-is to hidden.

rajdip_755 → created an issue.

Hey @ashutosh-ahirwal, thanks for the review. I have updated the MR to avoid using direct services using \Drupal.

I have removed the deprecated functions and add the corresponding services.
Please review the MR.
Thanks in advance !

I have raised the MR for resolving the issue, attaching here the screenshot of the admin/reports/w3c_validator page in gin and claro theme after applying the changes.
Please review the MR .

Thanks @John_B for providing the details.
I can replicate the issue and working on it !

@John_B Can you please attach screenshots so that I can exactly see where it is breaking for you?
Also can you please mention the Drupal version and the steps to reproduce the issue?
Thank you!

Raised the MR to resolve the issue, so please ignore the patch attached in #5 .
Please verify the changes !

Thanks @amandeep_lnwebworks for providing the exact permission. Your solution is working partially for me.

I have tried with providing the particular permission to all the roles ( which is not recommended in a production site ), and create a user with all the possible roles and try to login. It's working perfectly.

For further testing I've created another user with all the roles and try to login but unfortunately it replicated the same "Access Denied" error.
So that, I have created a patch which is working for me without providing the admin permission also. Please verify the following patch.

And I've attached here the message shown after the login.

Hello @amandeep_lnwebworks ! Thanks for response.
It will be helpful if you can please mention the particular permission name.
Another thing, I have tried to login with the admin user login credentials then also I faced the same issue, I think the Admin user role has all the permission by default.

rajdip_755 → created an issue.

I have applied this patch. It's working fine for me.

Hi @foxrip
Changing the state of the issue to the "needs review" as you have already added a patch.

Thanks @3li for the credit !

Thanks for the information @chaitanyadessai.
It's perfectly applied for the your mentioned version and working fine for me. Additionally, I'm changing the version of the issue.

Hi @chaitanyadessai , I'm installing the latest version of the module and try to add your MR changes as a patch by using the following link
https://git.drupalcode.org/project/role_hierarchy/-/merge_requests/2.patch
But it's showing me the following error.
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/role_hierarchy/-/merge_requests/2.patch

Can you please confirm me, whether I need to install any other versions of this module or not. It will be better if you can suggest any other way to test this.

Thanks !

Hi @imran1217 , I have also faced the same issue, I'm using the solution proposed by you. But, there is a problem if we use the --prefer-source option it is starting to track the files based on git, which is not-recommended for the client-project. To resolve that, we need to add the following lines inside the config and repository key of the composer.json file respectively.

"preferred-install": {
            "drupal/ckeditor_templates": "source"
        },

"ckeditor_templates": {
            "type": "vcs",
            "url": "https://github.com/drupal/ckeditor_templates.git"
        },

Alternatively, I have found that there is a little problem in the patch or MR we are using here which reproduces the issue mentioned in #136. I'm attaching here the updated patch also. Please verify whether the issue of applying patch is resolved or not.

Thanks !

While debugging the module, I have found this minor bug, fixed this using the following patch. Please try it and check whether the issue is resolved or not.
patch →

rajdip_755 → created an issue.

Thanks for the information @VijaySharma_89 but the issue you have mentioned can't be replicated to me, I have encountered a different errors of undefined method drupal_get_path which can be resolved by https://www.drupal.org/files/issues/2024-01-06/email_login_otp.1.1.2.rec... → just keep the changes of the Otp.php file.

Hi @ryanbuckley@gmail.com, You can check this thread, I have tried this one and working fine for me. https://www.drupal.org/project/captcha/issues/2736881#comment-13594561 →

Hi, @VijaySharma_89 can you please mention the steps to reproduce. I'm trying to reproduce the issue and I'm attaching here the configuration I have set up to reproduce.

Thanks @timo-vogt for figuring out this issue. working on it.

Thanks @Abdullah Yassin for this code. I have also faced the same issue and try out your code it's working fine for me.

rajdip_755 → made their first commit to this issue’s fork.

rajdip_755 → made their first commit to this issue’s fork.

rajdip_755 → made their first commit to this issue’s fork.