- 🇵🇹Portugal jcnventura
As a new feature, this is now for the 2.x branch.
- 🇮🇳India Prashant.c Dharamshala
Patch not applying on the latest tag/branch. In the Default branch (2.x) "Controller" does not exist. Cloned the repo and worked on tag 2.0.0-alpha1 to make the changes. Submitting the re-rolled patch requires reviews.
- 🇳🇱Netherlands RicardoPeters
From a security perspective, wouldn't it be interesting to see if people are trying with credentials that maybe don't have existing accounts, for instance former editors or admin/root attacks?
Seeing this comment:
// Only register failed login attempts for existing accounts.
- 🇳🇱Netherlands RicardoPeters
Rerolled patch vs 2.x fixed removed controller, and fixed additions from cleanup calls.
- 🇳🇱Netherlands RicardoPeters
I messed up the patch of #6, sorry bout that, #7 should be fine
- 🇺🇸United States wjackson Aiken, SC
Rerolled patch #7 to resolve failures against the recent commits to the login_history.module file.
- 🇺🇸United States wjackson Aiken, SC
The previous patch created an issue where when a failed login attempt was recorded, it used the time of the last successful log rather than the time of the failed login attempt. Additionally, the source branch was a bit out of date.
This branch should include the most recent changes from the 2.x version of the login_history module, the changes from the patch RicardoPeters → previously provided in #7 ✨ Register failed login attempt Needs review / #9 ✨ Register failed login attempt Needs review , and the change to record the time of the failed login.
The attached patch was created from the merge request referenced in #10 ✨ Register failed login attempt Needs review .