- Issue created by @3li
- ๐ฎ๐ณIndia Indranil Roy kolkata
Indranil Roy โ made their first commit to this issueโs fork.
- Assigned to Indranil Roy
- Merge request !143417828: Use batch process for initializing the users. โ (Merged) created by Indranil Roy
- Issue was unassigned.
- Status changed to Needs review
7 months ago 5:50am 5 April 2024 - Status changed to Needs work
7 months ago 8:02am 5 April 2024 - ๐ง๐ชBelgium kriboogh
Thanks, couple of things based on the diff.
So working with a batch is great, but the way it is implemented, all users are still loaded in one call. We need to initialise a sandbox inside the batch context, load all user id's there using just a entity query on the user storage and then let batch iterate over them (either per user or in batches of lets say 100 users) until we are finished.
Setting up the batch can also be done using the BatchBuilder class.
The methods of the new class don't use dependency injection. So either solve that, or move the batch handling into the existing service and just add the dependency injection for the messenger service there.
- ๐ฎ๐ณIndia Indranil Roy kolkata
Thanks @kriboogh for your suggestion, will surely work on this.
- First commit to issue fork.
- Status changed to Needs review
6 months ago 12:18am 16 May 2024 - Status changed to Needs work
5 months ago 11:08am 3 July 2024 - Status changed to Needs review
4 months ago 4:17am 10 July 2024 - Status changed to RTBC
4 months ago 5:10am 10 July 2024 - ๐ฎ๐ณIndia rajdip_755 kolkata
@kalash-j I have applied the updated MR as a patch in a drupal instance with 2256 numbers of users. It's working fine for me attaching below the screenshot of the installation process of the module using drush command and the UI.
Thanks !
-
kriboogh โ
committed 12162490 on 1.0.x authored by
Indranil Roy โ
Issue #3417828: Module cannot be installed with large user base
-
kriboogh โ
committed 12162490 on 1.0.x authored by
Indranil Roy โ
- ๐ฎ๐ณIndia kalash-j jaipur
@kriboogh is there any work left on this issue , or can you change the status of the ticket?
- Status changed to Fixed
3 months ago 10:41pm 1 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.