- Issue created by @3li
- ๐ฎ๐ณIndia Indranil Roy kolkata
Indranil Roy โ made their first commit to this issueโs fork.
- Assigned to Indranil Roy
- Merge request !143417828: Use batch process for initializing the users. โ (Open) created by Indranil Roy
- Issue was unassigned.
- Status changed to Needs review
3 months ago 5:50am 5 April 2024 - Status changed to Needs work
3 months ago 8:02am 5 April 2024 - ๐ง๐ชBelgium kriboogh
Thanks, couple of things based on the diff.
So working with a batch is great, but the way it is implemented, all users are still loaded in one call. We need to initialise a sandbox inside the batch context, load all user id's there using just a entity query on the user storage and then let batch iterate over them (either per user or in batches of lets say 100 users) until we are finished.
Setting up the batch can also be done using the BatchBuilder class.
The methods of the new class don't use dependency injection. So either solve that, or move the batch handling into the existing service and just add the dependency injection for the messenger service there.
- ๐ฎ๐ณIndia Indranil Roy kolkata
Thanks @kriboogh for your suggestion, will surely work on this.
- First commit to issue fork.
- Status changed to Needs review
about 1 month ago 12:18am 16 May 2024