- Issue created by @kopeboy
- Assigned to praveen rani
- last update
7 months ago 2 pass - Issue was unassigned.
- Status changed to Needs review
7 months ago 8:07am 25 April 2024 To resolve the above issue, I have created MR. Please review changes.
- Status changed to Needs work
6 months ago 3:02pm 26 May 2024 - 🇺🇸United States john.oltman
Thanks for the MR. There are a few issues that need fixing:
* Should be a blank line above the comment block above the class and after the last use statement (used to be there)
* The old use statement for ContainerAwareEventDispatcher can be removed
* The doc block for the __construct needs to be updated for the $event_dispatcher variable - First commit to issue fork.
- last update
6 months ago 2 pass - Status changed to Needs review
6 months ago 6:36am 27 May 2024 - 🇮🇳India atul_ghate
I have fixed the issue as per drupal coding standard, please review.
- 🇮🇳India rajdip_755 kolkata
Hi everyone!
I'm trying to review the MR 4 but I'm unable to reproduce the same issue mentioned in the description.
- While I'm trying to replicate the by installing the latest version of this module(4.0.2) using the composer then getting a different issue. The screenshot of the issue attached herewith
- But, if we are trying to replicate by cloning the target branch i.e 4.0.x of this project, then none of the issue is encountered.
It will be helpful if someone please mention the steps to reproduce for the issue mentioned in the description.
Thanks in advance!
- Status changed to Needs work
4 months ago 7:52pm 14 July 2024 - 🇺🇸United States john.oltman
The order of the parameters to the "dispatch" function is now backwards when using the new interface - they need to be reversed. Setting issue back to "needs work" so the MR can be adjusted.
- 🇨🇦Canada brunodbo
I am seeing the same error as mentioned in #8. As @rajdip_755 says in his comment, the fix for that problem (i.e., changing the
dispatch()
method's argument order, as mentioned in #9) is already in the 4.0.x branch (see https://git.drupalcode.org/project/forward/-/commit/322887d1df607c30fa2b...), so I think all that needs to be done is roll a new release that includes the fix. Raising this to critical as this prevents the module from functioning currently.