The provided patch makes the "redirect_response_subscriber" to be replaced as expected, and simplify the code of the domain source event subscriber, so it relies more closely on its parent without duplicating the code.
b-prod → created an issue. See original summary → .
@ikphilip I tried the patch and it solves the issue, allowing to save the field successfully.
OK, I figure that the 3.x branch already has taken this bug into account.
So I just post here a patch to fix this in the current release, awaiting the next one.
The new branch 3.0.x provides integration with CKEditor 5, and add a new CountDown feature.
There is no upgrade path from CKEditor 4 to CKEditor 5 at the moment.
If using the value property from the attributes variable, the rendered string cannot contains HTML. It would be better to use the $element['#value'] instead.
@hockey2112 We started to work on the upgrade few months ago, but actually we are missing some time to finish.
As said by @kreynen, patches are welcome, or you are welcome to fork the 3.x and make merge requests.
@Berdir I understand your point, however you should take this into account: having a multilingual site with 20 languages, and 30 vocabularies, leads to 600 pattern rules...
With pattern translations, you only have 1 rule per pattern, so 30 patterns for the vocabularies.
Moreover, each rule requires a unique ID, which also lead to headaches when it comes to organize this.
And last point, the patterns page with 600 rules is not a thing that can be managed when looking for updating a specific rule...
What would be your suggestions for such a case?
All fixed except TWIG definitions, as the provided fix is wrong.
This is not my day... Here is the correct patch, I hope.
Here is the correct patch, the previous is invalid.
Fixes the compatibility with PHP 8.2
There are 2 version, on declaring the property, the other creating a simple variable. The last version seems more logical, as the property is not used anywhere so it seems useless.
The patch uses the second variant.
Sorry, this issue is related to a patch from another issue: https://www.drupal.org/node/2799479 →
@darkim The module is currently not compatible with CKeditor 5.
This is already fixed in the 1.x branch, with several other issues.
I had a look on the 3410165-fix-the-issues branch, however there is nothing implemented...
@jifernandezs Sorry but the provided patch does not fix the compatibility with CKEditor 5 at all...
The plugin needs a full rewrite, with an upgrade path. We are working on this on a new branch, apart of this issue.
@rmathew this is not the case, after a fresh install the library is at the expected location:
/libraries/countup.js/dist/countUp.umd.js
Committed in the 3.x branch:
https://git.drupalcode.org/project/countup/-/commit/17bd1f3d10a6b9f8b8b3...
@jifernandezs Thank you, we will have a look on your patch.
Moving to CKeditor 5 requires a new major version for the module, and some explanation on the project page to specify the compatibility, so we will work on this.
This is an update to the previous patch, for the current 1.x branch.
here is a patch more global, which tries to fix this issue in a different way. Actually this issue is caused by the cache on run and could be easily fixed.
When defining a pattern inside a front theme, and previewing on another theme (admin or other), you get this error.
The patch also fixes compatibility with the ui_patterns_view integration.
The provided solution does not works well, it leads to merge the "stylesheet" and "preload" values, so we get:
rel="stylesheet preload"
@quietone I don't think this issue is definitively closed, as this bug still appear if you set the access to FALSE on a parent element of the file managed element, but not on the file managed element itself.
I confirm what @vincent.hoehn say: the 2.x version does not work at all, if I specify to keep only 1 revision, nothing happens.
For example, I have a node with 2860 revisions, none is deleted.
Here is a patch against current release (1.0-rc4).
Following patch tested for vue 3.x, with drush, composer (npm-asset), cloudflare and jsDelivr.
Installation configuration has been changed to use Vue 2 instead of Vue 2.
Please note that Cloudflare links for vue 2 version in current configuration (before changes) does not work.
Also fix some issues, like the _minified_ and _weight_ library options that were applied even if there were no library...
Patch below fixes this issue, and correct a typo in the dependencies definition.