- Issue was unassigned.
- πͺπΈSpain jifernandezs
I have updated the D10 module with CKEditor 5. I attach a patch .
- πͺπΈSpain jifernandezs
I have updated the D10 module with CKEditor 5. I attach a patch .
- Assigned to Fonski
- π±πΊLuxembourg B-Prod
@jifernandezs Thank you, we will have a look on your patch.
Moving to CKeditor 5 requires a new major version for the module, and some explanation on the project page to specify the compatibility, so we will work on this.
- π³π¬Nigeria chike Nigeria
I applied patch #6 but can't find the button on the CKEditor text format toolbar.
- π±πΊLuxembourg B-Prod
@jifernandezs Sorry but the provided patch does not fix the compatibility with CKEditor 5 at all...
The plugin needs a full rewrite, with an upgrade path. We are working on this on a new branch, apart of this issue.
- πΊπ¦Ukraine darkdim Kyiv
Referrer /admin/config/content/formats
Message InvalidArgumentException: Property label with value CountUp does not exist on Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->__construct() (line 52 of .../www/web/core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php).
Severity ErrorI've some error with enable countup module
- π±πΊLuxembourg B-Prod
@darkim The module is currently not compatible with CKeditor 5.
- πΊπΈUnited States kreynen
It looks like the CKEditor 5 work is being done in the 3.x branch https://git.drupalcode.org/project/countup/-/tree/3.x. If you're going to contribute a MR to try to move this forward, I think that would be where you'd want to branch from.
It would be really helpful to publish releases on https://www.drupal.org/project/countup β and include a note that current releases of the module are NOT compatible with CKEditor 5.
- πΊπΈUnited States hockey2112
Any updates on D10 CKeditor 5 compatability?
- π±πΊLuxembourg B-Prod
@hockey2112 We started to work on the upgrade few months ago, but actually we are missing some time to finish.
As said by @kreynen, patches are welcome, or you are welcome to fork the 3.x and make merge requests.
- π¦πΉAustria drupalfan2
I am using countup 3.x-dev and have the same problem.
I get this error message
Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "countup" CKEditor 5 plugin definition must have a plugin ID that starts with "countup_". in Drupal\ckeditor5\Plugin\CKEditor5PluginManager->processDefinition() (line 100 of core/modules/ckeditor5/src/Plugin/CKEditor5PluginManager.php).
when I am on /admin/config/content/formats/manage/full_html (edit Full HTML text editor format)
Additionaly I get similar error messages.
How can we move forward here to write/get a complete patch?
- Issue was unassigned.