Avoid direct drupal service calls

I will be working on it.

@ankitv18 I have use same version of the module and trying to replicate the issue but I have not get any error as you mentioned above, I use this command to check for the errors
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/custom/soembed/
and got some errors, mention in the attached screenshot.

Kindly give me the steps to replicate.

Thank you

Hi @girish_lnweb, I have also run the phpcs but can't replicating the issue as you mentioned in #3 .

Along with this I have checked lines mentioned by @ankitv18 in the codebase of the module and the \Drupal is used in those lines which is not good as per the Drupal Coding Standard, we should use the DI for those lines.

Thanks !

this latest change gives me this error

Error: Call to a member function moduleExists() on null in Drupal\soembed\Plugin\Filter\SoEmbedFilter->getEnabledProviders()

MR7 gets this working for me.

here is a patch for composer

Automatically closed - issue fixed for 2 weeks with no activity.