🇺🇸United States @Ki

Gin theme is applying filter to invert the color in:

.toolbar .toolbar-bar .toolbar-tab > .toolbar-icon.is-active::before {
  filter: invert(100%);
}

The attached patch attempts to override it, but I don't know if the module should continue overriding such new changes introduced by the theme, unless those changes render the module unusable.

What do you think?

Set 8.x-2.x branch as default.

Thanks.

Approved the MR.

Thanks.

Thanks for your offer, @smustgrave!

I've made you a co-maintainer.

Thanks.
Ki

Attempt to support ckeditor 5's behavior of saving content source in one line caused too much trouble. The behavior existed for a while and seems to have gone now.

I have reverted the regex back to old simple one. Instead, I've revised the regex for in-line URL option and updated the description for the "Replace in-line URLs" checkbox to "Recognize in-line URLs. Enable too if the wysiwyg editor saves the content source in one line."

The update has been released in beta-9 version for review and testing.

@mortona2k
If you are a new user of the module, please make sure that the filter for "Convert URLs into links" comes after. As mentioned in README, the order of filters is important for the soembed filter to work.

Thanks.

It seems one regex that works for one easily breaks another. I'll try to find time to do tests, but I'd appreciate those in the thread test their case and work together to come up with a regex that works for all cases. Or is that actually possible? Should we introduce a checkbox setting to handle ckeditor5 as an exceptional case? Since ckeditor5 merges all lines into one in the backend, it is essentially no different from the option setting "Replace in-line URLs"

With the goal of being "simple", we won't want to support additional settings per video, unless the video provide lets you embed granular settings as part of the video URL.

We could consider supporting global video settings for the site in the filter settings. Property values entered in the textbox could be added to the

Peter Törnstrand

I've applied loze's patch and pushed to the latest 8.x-2.x-dev version.

Could you it works for you?

Thanks.
Ki

Applied the fix.

This is almost identical to the pattern for `Replace in-line URLs` option, though. Now I wonder if I should get rid of the option, which is getting irrelevant.

We'd need to come up with a regex that works with ckeditor 4, ckeditor 5, and no editor. Will the suggested fix satisfy it?

It was not easy to find regex to handle different scenarios. Pushed the fix in the release 8.x-2.0-beta7.

Released in 8.x-2.0-beta6

Released in 8.x-2.0-beta5

Released in 8.x-2.0-beta5

Could you make a cleaned-up MR or post a patch file?

Thanks.

I have a similar need too. I have an old Drupal 8 site and I am building a new Drupal 10 site with content types that are different from those of D8 site. So I can't upgrade the D8 site in place, but simply want to migrate the content only. Running the drush command `drush migrate-upgrade` on the D8 legacy database does not produce the migration config yaml files. I suppose I'll have to write the yml files manually. It's too bad that D7>D9 is very easy with this module, but D7>D10 is not.

This patch works with version 3.1.0

@almunnings,

Thanks for the quick response! It works great.
I think it's fine to limit parents from the same vocabulary only. Drupal core UI does not allow multi-vocab parents anyway.

Ki

Ki → created an issue.

Updated the #6 patch for Drupal 9.5.7

If you use PHP 7.x and get the PHP error, "TypeError: explode() expects parameter 2 to be string, bool given in explode()", apply this patch.

Fix deployed in 8.x-2.0-beta4

Thanks, @minnur!

Thanks, guys, for taking care and making suggestions!

I agree that the priority should be on the core Claro theme. I tried to focus on Gin theme support and ended up rendering (Claro) classic Toolbar to resemble that of Gin. I decided Toolbar coloring does need not need to be similar between Claro and Gin.

Fix has been deployed to 2.1.4.

@mmbk,
It was challenging to color the whole toolbar. I will give it another try. Fix suggestion is welcome.

Included in ver 2.1.2

Included in ver 2.1.2

Ki → made their first commit to this issue’s fork.

I've added support for the foreground text color in the release 2.1.1.