- πΊπΈUnited States loze Los Angeles
Thanks for committing this.
After using it for a while I noticed that if there are many urls in the field ,and some are not oembed urls, or some are dead urls that go nowhere, the call to getProviderByUrl() still attempts to ping the url even if its not in the provider repository. This causes a big performance hit when filtering the text.
We should have our own method in the filter that checks if the url is a known provider and return early if it is not.
I have a follow up patch for this coming.
- @loze opened merge request.
- πΊπΈUnited States loze Los Angeles
I don't think I did this right. Im still trying to get a hang of the issue forks on here. I was trying to post these changes
https://git.drupalcode.org/issue/soembed-3260982/-/commit/c4f42eda18492a...
Not sure where I went wrong. My apologies for the mess.
This adds a private method to the filter for getProviderByUrl() that only checks the known providers without trying to get the url.
- πΊπΈUnited States Ki
Could you make a cleaned-up MR or post a patch file?
Thanks.
- πΊπΈUnited States loze Los Angeles
Sorry about all that. Here is a patch.
- Status changed to Fixed
10 months ago 1:47am 21 January 2024