- Issue created by @bserem
- ๐ซ๐ฎFinland vermario
For me it's a bit of a regression to not color the whole toolbar, since the main point of this module is to clearly differentiate between environments to prevent users changing things in the wrong environment (like deleting a section in production when they actually think they are in staging etc).
So I would also suggest to restore the styling of the full toolbar, unless there's some big technical impediment.
- ๐ฉ๐ชGermany mmbk Meiรen
Hmm, this is an regression, the problem was fixed in 2.0.0-beta1, but reappeared later :-(
See https://www.drupal.org/project/simplei/issues/3327481 ๐ฑ Version 2.x feedback Fixed - ๐บ๐ธUnited States Ki
@mmbk,
It was challenging to color the whole toolbar. I will give it another try. Fix suggestion is welcome. - ๐ฌ๐ทGreece bserem
In my opinion Claro should take priority over gin, since it's the default admin theme provided by core.
At the moment the latest version is compatible only with Gin but not with Claro (text and colour)
I'll give it look tomorrow, I can dedicate a couple of hours on this
- Status changed to Needs review
over 1 year ago 5:06am 2 March 2023 - ๐บ๐ธUnited States Ki
I agree that the priority should be on the core Claro theme. I tried to focus on Gin theme support and ended up rendering (Claro) classic Toolbar to resemble that of Gin. I decided Toolbar coloring does need not need to be similar between Claro and Gin.
Fix has been deployed to 2.1.4.
- ๐ซ๐ฎFinland vermario
Fantastic! thank you for fixing this so quickly! ๐
- Status changed to Fixed
over 1 year ago 7:33am 2 March 2023 - Status changed to Fixed
over 1 year ago 1:36pm 2 March 2023 - ๐บ๐ธUnited States Ki
Thanks, guys, for taking care and making suggestions!