Version 2.1 renames "Manage" in toolbar, only colors the first item

Created on 1 March 2023, over 1 year ago
Updated 2 March 2023, over 1 year ago

Problem/Motivation

Up until v1 the toolbar was styled like

but from v2.1 it looks like

  • The "Manage" item is gone from the toolbar, replaced with the environment name
  • Renaming the toolbar item is confusing for non-tech people ("what does PROD mean?")
  • Coloring only happens on the first item, the rest of the toolbar is a gold gradient

Steps to reproduce

Update to (or install) v2.1.3

Proposed resolution

Style things like v1

๐Ÿ› Bug report
Status

Fixed

Version

2.1

Component

Code

Created by

๐Ÿ‡ฌ๐Ÿ‡ทGreece bserem

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @bserem
  • ๐Ÿ‡ซ๐Ÿ‡ฎFinland vermario

    For me it's a bit of a regression to not color the whole toolbar, since the main point of this module is to clearly differentiate between environments to prevent users changing things in the wrong environment (like deleting a section in production when they actually think they are in staging etc).

    So I would also suggest to restore the styling of the full toolbar, unless there's some big technical impediment.

  • ๐Ÿ‡ฌ๐Ÿ‡ทGreece bserem
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany mmbk MeiรŸen

    Hmm, this is an regression, the problem was fixed in 2.0.0-beta1, but reappeared later :-(
    See https://www.drupal.org/project/simplei/issues/3327481 ๐ŸŒฑ Version 2.x feedback Fixed

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States Ki

    @mmbk,
    It was challenging to color the whole toolbar. I will give it another try. Fix suggestion is welcome.

  • ๐Ÿ‡ฌ๐Ÿ‡ทGreece bserem

    In my opinion Claro should take priority over gin, since it's the default admin theme provided by core.

    At the moment the latest version is compatible only with Gin but not with Claro (text and colour)

    I'll give it look tomorrow, I can dedicate a couple of hours on this

    • Ki โ†’ committed 7cfc2382 on 2.x
      Issue #3345169: Version 2.1 renames "Manage" in toolbar, only colors the...
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States Ki

    I agree that the priority should be on the core Claro theme. I tried to focus on Gin theme support and ended up rendering (Claro) classic Toolbar to resemble that of Gin. I decided Toolbar coloring does need not need to be similar between Claro and Gin.

    Fix has been deployed to 2.1.4.

  • ๐Ÿ‡ซ๐Ÿ‡ฎFinland vermario

    Fantastic! thank you for fixing this so quickly! ๐Ÿ‘

  • Status changed to Fixed over 1 year ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany mmbk MeiรŸen
  • ๐Ÿ‡ฌ๐Ÿ‡ทGreece bserem

    That was fast! Thanks @ki

  • Status changed to Fixed over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States Ki

    Thanks, guys, for taking care and making suggestions!

Production build 0.69.0 2024