Doesn't it make sense to implement this feature in a separate module, so that it can be used by other mail-sending-modules?
Sorry #17 had a wrong base, patch corrected
PAtch #13 does not apply to D10.2.2 anymore. Attached the patch without functional changes
mmbk → made their first commit to this issue’s fork.
Si - that's OK, but woukd you mind to set the issue to RTBC if you think it's working?
Hi - I just added the patch for this in the original issue: https://www.drupal.org/project/honeypot/issues/3344479 ✨ Fix Expire description in tour Fixed
The updatehook 8104 fails when the tour module ist not installed.
So it has to be checked whether the service exists.
Patch is attached
Hmm this would be a patch for this module, but you added the attribute already.
Might be a browser issue as well, but I'm using the same browser in different tabs the stage (OK) and the localdev (Not OK)
Sure - We are using GIN and I'm work with FF 115
The patch for save composer inclusion
Yes, I just needed the same feature, this is working perfectly.
Yes it's working and not crashing anymore
Found a problem here
+++ b/src/Plugin/views/area/ViewsAddButtonArea.php
@@ -326,7 +323,7 @@ class ViewsAddButtonArea extends TokenizeAreaPluginBase {
- $text = $this->options['button_text'] ? $this->options['button_text'] : 'Add ' . $bundle;
+ $text = $this->options['button_text'] ? $this->options['button_text'] : $this->t('Add @bundle', ['@bundle' => $bundle]);
$text = $this->options['tokenize'] ? $this->tokenizeValue($text) : $text;
$text = t($text);
Found a problem here, when no custom text is configured, the t() in line 329 fails, because the argument is missing.
module is working without problem on D10, patch already merged into 2.0.x, so it's fixed?!
Patch #4 works as expected.
Working as expected, the nodes are counted correctely now!
Implemented a view style for the slider.
The slider is configurated by a list of classes, that shall be applied to the slider.
There is a link to the swiffy slider configuration values, so that the classes can be easyly checked and changed.
There is a settings form, where the default classes, that are normally used on your site can be entered. These classes are inserted whenever a new view style is created.
I created an service for parsing of the configurator url and the used formfields. This service can be used by the field formatter as well. But I did not touch the formatter (this would be a different issue)
While looking at the parser, I found that the style attributes are not parsed correctly. Further more I did not understand why the data-* attributes are parsed, as I do not see where they are created by the configurator. Nevertheless I did not change the parser, and marked the location with @todo
@hexabinaer but the url is not readable at all. It would be useful if only the options are diplayed. (comma separated)
A local git apply is always helpfull o_O
Patched - Render the link as link.
Hmm I don't see the reason why the the composer install fails - as it is working in #3286790 📌 Automated Drupal 10 compatibility fixes Fixed
This module is well covered by automated tests and all tests completed succeessfully for D9 & D10.
As this issue blocks upgrading existing sites from D9 => D10 I see no reason not to merge it.
Hmm, this is an regression, the problem was fixed in 2.0.0-beta1, but reappeared later :-(
See
https://www.drupal.org/project/simplei/issues/3327481
🌱
Version 2.x feedback
Fixed
Hmm, imho hook_help() is not mandatory. But a nice-to-have, but if it is present, I think it should explain, how it should be used. Personally I don't see any added value, when the description appears in the help section.
Hmm, @fenstrat the widget with the merge request contains a link plain diff that can be used for the composer patches.
upgrade_status says the `core_version_requirement` is the only D10 issue in this project, so it is working.
The failing test with postgres is not generated by this patch, it already fails with the 10.1.x-dex branch https://www.drupal.org/node/3060/qa →
Working without problems with Drupal 10.0
This is working as expected. Seven & Claro Toolbars are colored nicely.
What kind of test do you mean ?
User testing or automated test.
I mean automated tests, they were already suggested at #15 🐛 Radios element missing "required" attribute Needs work
Should i be the one to put the issue on RTBC
No definately not, I'ld like to have a review by a more experienced contributor
@edwin-knol thank you for your work here, for me the result looks good.
I just wonder whether we need some tests here, if not I think it's RTBC