- Issue created by @hexabinaer
- First commit to issue fork.
- @tobiasb opened merge request.
- Status changed to Needs review
over 1 year ago 1:23pm 19 April 2023 - Status changed to RTBC
over 1 year ago 6:51am 20 April 2023 - ๐บ๐ธUnited States laboratory.mike
Thanks Tobias for the patch. I'll review it in the near future and get it merged in.
- Assigned to mmbk
- Status changed to Needs work
over 1 year ago 6:35am 21 April 2023 - ๐ฉ๐ชGermany mmbk Meiรen
Found a problem here
+++ b/src/Plugin/views/area/ViewsAddButtonArea.php @@ -326,7 +323,7 @@ class ViewsAddButtonArea extends TokenizeAreaPluginBase { - $text = $this->options['button_text'] ? $this->options['button_text'] : 'Add ' . $bundle; + $text = $this->options['button_text'] ? $this->options['button_text'] : $this->t('Add @bundle', ['@bundle' => $bundle]); $text = $this->options['tokenize'] ? $this->tokenizeValue($text) : $text; $text = t($text);
Found a problem here, when no custom text is configured, the t() in line 329 fails, because the argument is missing.
- ๐ฉ๐ชGermany tobiasb Berlin
I did not saw
$text = t($text);
. This can then be removed. Because when configured via views -> translate it via config translation, when the button_text is empty useAdd @bundle
-> can be translated via UI-Translation. - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 7:09am 21 April 2023 - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:24am 21 April 2023 - ๐ฉ๐ชGermany tobiasb Berlin
The default button text was the bundle ID. I changed the patch so that it use the bundle label.
-
laboratory.mike โ
committed 9caf8b86 on 2.0.x authored by
tobiasb โ
Issue #3351528 by tobiasb, sourabhjain, mmbk, hexabinaer, laboratory....
-
laboratory.mike โ
committed 9caf8b86 on 2.0.x authored by
tobiasb โ
- Status changed to Fixed
over 1 year ago 7:36pm 3 June 2023 - ๐บ๐ธUnited States laboratory.mike
Thank you for your contribution @tobiasb! I've merged this into the codebase, and will include it in the next release.
Automatically closed - issue fixed for 2 weeks with no activity.