- Issue created by @RobLoach
- First commit to issue fork.
- 🇭🇷Croatia valic Osijek
I am more in favor of declaring that it can be either NULL or string.
getScopes as I see is called upon like this
$extra_scopes = $this->getScopes(); if ($extra_scopes) { $scopes = array_merge($scopes, explode(',', $extra_scopes)); }
where it's better that we return either NULL or correct string
- 🇮🇳India rajdip_755 kolkata
I reviewed the MR's code, and it looks good to me.
Moving the issue to RTBC. Thanks!