Osijek
Account created on 12 October 2010, almost 15 years ago
#

Merge Requests

More

Recent comments

🇭🇷Croatia valic Osijek

The initial dev version is out. 2 years later :-D

Now I really need this integration

https://www.drupal.org/project/commerce_revolut/releases/1.0.x-dev

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

I don't see it as needed, from perspective of per example commerce_currency_resolver, I did now wrote three resolvers with different weights, so they can be used even simultaneously, etc: cookie resolver first, if there is no cookie, geo resolver goes next, etc..

Don't have need to interact with getResolvers()

🇭🇷Croatia valic Osijek

1. Yes, it's not used anymore currently, so there is no changes in any of existing API-s.
2. Expanding context maybe have a sense, but it would introduce BC for that part. For majority of the shops probably which are single currency it does not benefit them, only multi currency which again is granulated how it's implemented

I am OK to RTBM this.

I did test with couple of my resolver, language, etc, it works great

Example of resolving per user language

🇭🇷Croatia valic Osijek

You need than install commerce_exchanger version 2

🇭🇷Croatia valic Osijek

8.x-1.61 is pretty old release, can you try with never version

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

You need to add to your settings.php this line

$settings['commerce_currency_cookie'] = 'STYXKEY_commerce_currency;
🇭🇷Croatia valic Osijek

Updated the MR, $result variable had been undefined. And there is no reason to check if $job exist, at that point because of earlier check's it should exist https://git.drupalcode.org/project/advancedqueue/-/merge_requests/10/dif...

And unit tests are passing again

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

We need to update as well ContentEntityType and ConfigEntityType to attribute

🇭🇷Croatia valic Osijek

Opened the second PR with prefixed payment gateway method names (braintree_google_pay, braintree_apple_pay). Included a fix from #28

The failing PHPstan is not related to this work

https://git.drupalcode.org/project/commerce_braintree/-/merge_requests/22

🇭🇷Croatia valic Osijek

valic changed the visibility of the branch 3261609-apple-and-google to hidden.

🇭🇷Croatia valic Osijek

Configurable on form display

🇭🇷Croatia valic Osijek

I am more in favor of declaring that it can be either NULL or string.

getScopes as I see is called upon like this

    $extra_scopes = $this->getScopes();
    if ($extra_scopes) {
      $scopes = array_merge($scopes, explode(',', $extra_scopes));
    }

where it's better that we return either NULL or correct string

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

+1 for adding a new co-maintainer.

If I can add a comment it may be best to contact https://www.drupal.org/u/deadbeef for this.

I see all maintainers are from the same company ( https://www.drupal.org/digitalist ), which means some of them may not even be working there, but deadbeef is head of that agency (by his profile title)

🇭🇷Croatia valic Osijek

Can we get this merged, it's blocking D11 updates.

btw. seems we are requesting drupal/varnish_purge, but in composer json is specified drupal/varnish_purger - assuming that is reason why I can't just fetch the branch directly
https://git.drupalcode.org/project/varnish_purge/-/blob/8.x-2.x/composer...

🇭🇷Croatia valic Osijek

Added compatibility for D11

I think we should switch to `smolblog/oauth2-twitter` which is listed as X League2 community provided package.

It makes implementation the plugin much in line with existing logic for 4.x

Still work in progress, but I can get to X screen / login

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

valic made their first commit to this issue’s fork.

🇭🇷Croatia valic Osijek

good enough for the start

Production build 0.71.5 2024