🇭🇷Croatia @valic

I am more in favor of declaring that it can be either NULL or string.

getScopes as I see is called upon like this

    $extra_scopes = $this->getScopes();
    if ($extra_scopes) {
      $scopes = array_merge($scopes, explode(',', $extra_scopes));
    }

where it's better that we return either NULL or correct string

valic → made their first commit to this issue’s fork.

+1 for adding a new co-maintainer.

If I can add a comment it may be best to contact https://www.drupal.org/u/deadbeef → for this.

I see all maintainers are from the same company ( https://www.drupal.org/digitalist → ), which means some of them may not even be working there, but deadbeef is head of that agency (by his profile title)

Can we get this merged, it's blocking D11 updates.

btw. seems we are requesting drupal/varnish_purge, but in composer json is specified drupal/varnish_purger - assuming that is reason why I can't just fetch the branch directly
https://git.drupalcode.org/project/varnish_purge/-/blob/8.x-2.x/composer...

Added compatibility for D11

I think we should switch to `smolblog/oauth2-twitter` which is listed as X League2 community provided package.

It makes implementation the plugin much in line with existing logic for 4.x

Still work in progress, but I can get to X screen / login

valic → made their first commit to this issue’s fork.

update example

valic → created an issue.

valic → created an issue.

valic → made their first commit to this issue’s fork.

valic → made their first commit to this issue’s fork.

valic → created an issue.

good enough for the start

valic → created an issue.

valic → created an issue.

valic → created an issue.

valic → made their first commit to this issue’s fork.

valic → created an issue.

valic → created an issue.

Only Commerce Core requirements needed to be raised

valic → made their first commit to this issue’s fork.

valic → created an issue.

valic → created an issue.

valic → created an issue.

valic → created an issue.

Added new release https://www.drupal.org/project/commerce_currencies_price/releases/2.0.2 →

True, missed that one

valic → changed the visibility of the branch 3039854 to hidden.

valic → changed the visibility of the branch 3039854-add-a-currency to hidden.

valic → created an issue.

valic → made their first commit to this issue’s fork.

valic → made their first commit to this issue’s fork.

The original MR should have been agains 2.0.x not 8.x branch. Rebased now

valic → made their first commit to this issue’s fork.

valic → made their first commit to this issue’s fork.

Unit tests are failing, but will deal with it in separate issue

Pipelines are passing, merging

Can we merge this? Getting blocked on some dependant project.