- last update
8 months ago 787 pass - @valic opened merge request.
- 🇭🇷Croatia valic Osijek
Can we revive this :-D
Pushed code from @zaporylie and added some basic test coverage for chain resolver and current currency
- last update
8 months ago 791 pass
Commerce has the concept of a current country, locale, store.
It also has price resolvers, which allow selecting a price based on these, or other factors.
What it doesn't have is the concept of a current currency, that could be used by price resolvers.
This would be useful for example in Commerce Pricelist, cause it would allow defining prices per-currency and having them automatically selected. Relevant contrib module: http://drupal.org/project/commerce_currency_resolver
So, the plan is:
- CurrentCurrency and CurrentCurrencyInterface in \Drupal\commerce_price
- CurrencyResolverInterface, ChainCurrencyResolverInterface, ChainCurrencyResolver in \Drupal\commerce_price\Resolver
- StoreCurrencyResolver in \Drupal\commerce_store\Resolver which returns the store currency.
That means no DefaultCurrencyResolver in commerce_price, cause we have nothing to base the decision on, except returning the first alphabetical defined currency, which doesn't feel very useful.
Needs work
2.0
Other
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Can we revive this :-D
Pushed code from @zaporylie and added some basic test coverage for chain resolver and current currency