Media type creation test coverage

Not getting anywhere with this one. Tests are not my strong point so setting to Needs Work! Anyone who has a deeper knowledge, feel free to duck in!

daniel.j → made their first commit to this issue’s fork.

Looking good. There is a phpcs error still though.

85 | WARNING | Unused variable $media. (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
135 | WARNING | Unused variable $media. (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)

Looks like not even the composer tests are passing, I'll look into that, sorry for the inconvenience !

Appologies, I meant to follow up with a comment after pushing changes but got cought up with something else.

The tests added are for the form, I hope to follow up with some tests for the media plugin itself. I'll be happy to clean up the tests already pushed as well for cs and stan issues.

CI all green. Please see https://www.drupal.org/project/drupal/issues/3532187 🐛 Composer issue when dealerdirect/phpcodesniffer-composer-installer update from v1.0.0 to v1.1.0 Active with regards to the composer issue.

Changes added include Unit and Kernal tests for 'MediaEntityLink.php', also fixes for composer, phpcs, phpstan.

Please review the tests.

Looking good. Tests pass. Pipelines pass. This is awesome. Great work! @danrod are you happy for me to commit this?

Hi @d.fisher I'm ok with this, please do commit !
Great work !

@daniel.j , thanks a lot of the information. I was having the same issue with some projects and I'll apply that solution.

Thank you everyone for all your efforts. Great to finally get this one merged, released, and marked as fixed!!