- Issue created by @scott_euser
- π¬π§United Kingdom d.fisher
Agree with RTBC. Just encountered this issue and the merge request fixed it for me.
Just encountered this issue and the merge request seems to have resolved the issue here too
- π§π·Brazil pfeiffer
After applying the attached patch (extracted safely from MR !33), the following fatal error is resolved:
PHP Fatal error: Declaration of Drupal\path_redirect_import\Drush\Commands\PathRedirectImportCommands::create(ContainerInterface $container): Drupal\migrate_tools\Drush\Commands\MigrateToolsCommands must be compatible with ...::create(ContainerInterface $container): static
- πΊπΈUnited States papagrande US West Coast
To keep this from happening a third time, I suggest tighter dependency restrictions in the info and composer.json files.
And could automated tests have caught this?
- πΊπΈUnited States papagrande US West Coast
Adding the actual error to help the search bots.
- πͺπΈSpain plopesc Valladolid
As mentioned in #8 π Compatibility with Migrate Tools 6.0.x-dev Active , the patch should include changes in composer and info files to ensure that new module version including this change will work with migrate_tools ^6.1.0.
It's hard to define a tighter dependency because we don't have the exact information about when the parent module will introduce new changes in the parent class constructor.
- π¬π§United Kingdom scott_euser
Okay and from there on your end you'll then create new branch as appropriate? Or do we do this in 2.1.x?
- πͺπΈSpain plopesc Valladolid
Do not worry about branches. I'll take care of them. Thank you!
- π¬π§United Kingdom scott_euser
Okay updated info yml and composer json minimum versions, thanks!
- πΊπ¦Ukraine dburiak
Works as expected with Migrate Tools 6.1.0
Thanks! Moving the ticket to RTBC. -
plopesc β
committed 7f2809c6 on 2.1.x authored by
scott_euser β
Issue #3531442: Compatibility with Migrate Tools 6.1.0
-
plopesc β
committed 7f2809c6 on 2.1.x authored by
scott_euser β
- πͺπΈSpain plopesc Valladolid
MR merged and released v2.1.1
https://www.drupal.org/project/path_redirect_import/releases/2.1.1 β
Thank you!