- π¬π§United Kingdom d.fisher
Just coming along to update this issue. 2.0.x is now the default branch and is listed on the project page. This branch has not had a tagged release in over 2 years. Ideally we will tag a new release of this branch soon so that the module is Drupal 11 compatible and includes all the other good fixes that have been merged over the past 2+ years. This will also allow us to test all the open issues in the issue queue against a tagged release which will give us a new jumping off point for cleaning up the issue queue and getting some of these issues resolved once and for all!
- πΊπΈUnited States dasginganinja Bethlehem, PA
Can you release a d11 compatible alpha or something for 2.x? Please.. Please
- πΊπΈUnited States alison
Oof, I'm really sorry it's been like this. I think "a compatible alpha or something" could be doable -- I'm nervous about it, since I really can't do any work to review/test anything, but, if the 2.x branch on its own isn't sufficient for folks to use on D11 as-is, ...probably we should release an "alpha or something"...
@darren.fisher what do you think, is that a terrible idea or an "okay" idea or?
It looks good tbh and I reviewed these two, which is great work from Darren:
- https://www.drupal.org/project/nodeaccess/issues/3357718 π Warning: Undefined array key "rid" + Trying to access array offset on value of type null in nodeaccess_node_access() Active
- https://www.drupal.org/project/nodeaccess/issues/3144313 β¨ Preserve role grants when adding custom grants on node Needs workIMO, we can merge the two and tag a new alpha with D11 support.
- π¬π§United Kingdom d.fisher
Agreed. I think tagging a new alpha with D11 support is desperately needed. The whole idea of an alpha release is something stable enough to test but not recommended for production sites. This will at least allow more people to test the module on Drupal 11 and report any issues.
- πΊπΈUnited States alison
Okay I'm sold, I'll create 2.0.0-alpha3 with D11 support.
@darren.fisher do you want to merge π Warning: Undefined array key "rid" + Trying to access array offset on value of type null in nodeaccess_node_access() Active and β¨ Preserve role grants when adding custom grants on node Needs work first, or should I do it with what we have now?
- π¬π§United Kingdom d.fisher
I think they both need work still so I'd go with just tagging what has already been merged.
- πΊπΈUnited States alison
Ok! Done!!!!!!!
https://www.drupal.org/project/nodeaccess/releases/2.0.0-alpha3 βThanks so much for all the work, everybody -- if there are any urgent issues with the release, message me on Drupal Slack (@alison).