- Issue created by @d.fisher
- last update
over 1 year ago 6 pass - Status changed to Needs work
14 days ago 7:04am 23 May 2025 - 🇪🇸Spain marcoscano Barcelona, Spain
I am not too familiar with videoask, but this PR is basically just allowing to embed anything from any URL, which defeats a little bit the purpose of the per-plugin providers architecture. If we could restrict the URLs accepted to something that's unique to this provider, it would be better.
Thanks! - 🇬🇧United Kingdom d.fisher
Yeah this merge request needs rebasing and that regex looking at. Not sure why I did it like that in the end? I'll take another look.
- 🇬🇧United Kingdom d.fisher
Ah. I've just refreshed myself. Videoask is a premium service and as a result gets set up as a subdomain of your own domain. If you were drupal.org for example and you wanted to use videoask as the custom subdomain your videos would live at videoask.drupal.org/s0m3rand0m1d
That regex is currently matching and HTTPS url that:
1. Starts with https://
2. Has at least one character after the domain
3. Ends with a path segment composed of letters, digits, or hyphensThis could indeed match pretty much any URL and isn't fit for purpose. Perhaps this particular plugin would need a page in the UI where you can enter the custom domain which hosts your videoask videos so that this can then be used to match?
- 🇪🇸Spain marcoscano Barcelona, Spain
Maybe the formatter settings can have this extra field where we could store the domain, since this is specific to this provider.