- Issue created by @ptmkenny
- 🇯🇵Japan ptmkenny
The current MR ONLY adds attribute support without actually adding the attribute to the plugins. The reason is because attributes will break on PHP < 8.1 and don't work with Drupal < 10.2. Since this module supports older versions of Drupal, addition of attributes to plugins should be postponed, but the Attribute itself can be committed now so that downstream modules (with stricter version requirements) can start using it.
- First commit to issue fork.
- Status changed to Needs review
2 months ago 12:23pm 22 April 2025 - First commit to issue fork.
- 🇯🇵Japan ptmkenny
As per #8, I think this is ready to go, but if it gets committed, we should create a follow-up issue to actually use the attributes within Key and then drop the annotations when Key requires at least Drupal 10.2.
- Merge request !55Add support for PHP attributes and require Drupal 10.2 → (Open) created by ptmkenny
- 🇯🇵Japan ptmkenny
Now that there is a 2.x branch of Key, we should do the full conversion and require Drupal 10.2.
- 🇯🇵Japan ptmkenny
Ok, this is now working again.
The MR adds support for PHP attributes (adds attribute classes for Key's three annotations) and converts Key's built-in plugins to use the new attributes instead of annotations.
This requires Drupal 10.2 at a minimum.
I have moved this to the 2.x branch but it could be part of 1.x if 1.x gets bumped to 10.2+.
- First commit to issue fork.