Contrib.social

Coding standards issues

Open on Drupal.org →
Created on 5 December 2024, 5 months ago

Problem/Motivation

Currently, the module contains inconsistencies in code formatting that do not adhere to the Drupal Coding Standards (Drupal Coding Standards and DrupalPractice). These inconsistencies make the code less readable and can create challenges during code review, in addition to impacting long-term maintainability.

The motivation for this issue is to align the module's code with the recommended standards, making it easier for the community to contribute and ensuring the code is clearer, more maintainable, and compatible with static analysis tools.

By implementing these changes, the module will better align with the Drupal community’s policies, and the effort required for future updates or reviews will be reduced.

Steps to reproduce

  1. Clone the repo
  2. cd colorbox
  3. run phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .

Proposed resolution

Fix reported errors and warnings
FILE ERRORS WARNINGS
----------------------------------------------------------------------
...eldFormatter/ColorboxEntityReferenceFormatter.php 0 2
.../contrib/colorbox/styles/plain/colorbox_style.css 1 0
...orbox/styles/stockholmsyndrome/colorbox_style.css 3 0
----------------------------------------------------------------------
A TOTAL OF 4 ERRORS AND 2 WARNINGS WERE FOUND IN 3 FILES

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

2.1

Component

Code

Created by

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024