undefined - Contrib.social

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

I'm taking a look and working on it

📌 | File Entity (fieldable files) | Coding standards issue

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | SVG Image Field | Coding standards issues

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

I've made some changes, waiting for a review.

Thanks

📌 | SVG Image Field | Coding standards issues

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | Views Contextual Filters OR | Coding standards issues 7.x-1.x

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

I've already submitted a commit with some changes, but there's some work to to:

FILE: ...ters_or/plugins/views_contextual_filters_or_search_api_query.inc
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 11 | ERROR | Class name must begin with a capital letter
 11 | ERROR | Class name must use UpperCamel naming without
    |       | underscores
 16 | ERROR | Public method name
    |       | "views_contextual_filters_or_search_api_query::option_definition"
    |       | is not in lowerCamel format
 31 | ERROR | Public method name
    |       | "views_contextual_filters_or_search_api_query::options_form"
    |       | is not in lowerCamel format
----------------------------------------------------------------------


FILE: ...textual_filters_or/plugins/views_contextual_filters_or_query.inc
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
 11 | ERROR | Class name must begin with a capital letter
 11 | ERROR | Class name must use UpperCamel naming without
    |       | underscores
 16 | ERROR | Public method name
    |       | "views_contextual_filters_or_query::option_definition"
    |       | is not in lowerCamel format
 31 | ERROR | Public method name
    |       | "views_contextual_filters_or_query::options_form" is
    |       | not in lowerCamel format
 48 | ERROR | Public method name
    |       | "views_contextual_filters_or_query::add_where" is not
    |       | in lowerCamel format
 61 | ERROR | Public method name
    |       | "views_contextual_filters_or_query::add_where_expression"
    |       | is not in lowerCamel format
----------------------------------------------------------------------

📌 | Views Contextual Filters OR | Coding standards issues 7.x-1.x

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

📌 | Views Contextual Filters OR | Coding standards issues 7.x-1.x

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | Colorbox | Coding standards issues

Comment 13 days ago →

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

I've already made a commit with the solution 1274dd6b6332520f42faea82e35a1af7251f1761 in the 3491900-coding-standards-issues branch but I cant make a Merge Request

📌 | Colorbox | Coding standards issues

Comment 13 days ago →

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | Search API attachments | Coding Standard Issues

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

📌 | Search API attachments | Coding Standard Issues

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | Field Group | Fix coding standard

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

📌 | Field Group | Fix coding standard

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | Quick Tabs | Fix coding standards

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

📌 | Quick Tabs | Fix coding standards

Comment about 2 months ago →

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → created an issue.

📌 | Token | Prevent that the token browser is opened more than once

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

Hi there,

I'm taking a look at this issue. I'll update here once I've made some progress.

Cheers

🐛 | Colorbox | Custom caption with tokens doesn't render HTML characters

Comment about 2 months ago →

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

I was able to replicate the error you mentioned in a local environment, as shown in the screenshots below:

Alternative text configuration

Sourcecode without entity

Alt text without entity

To address this, I added \Drupal\Component\Utility\Html::decodeEntities to Xss::filter($caption) in the _colorbox_formatter_get_caption function located in web/modules/contrib/colorbox/colorbox.theme.inc. I also committed this solution to the 3469260-custom-caption-with-tokens branch.

After clearing the cache, the updated results can be seen in the following screenshots:

Source code with entity

I am submitting the ticket for review and am available for any suggestions or feedback.

🐛 | Colorbox | Custom caption with tokens doesn't render HTML characters

Comment about 2 months ago →

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

ismaelromero → made their first commit to this issue’s fork.

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

The issue was due to the required jquery.colorbox-min.js library missing from the libraries folder.

The folder structure was as follows:

./libraries
└── dompurify
    └── dist
        ├── purify.cjs.js
        ├── purify.cjs.js.map
        ├── purify.es.mjs
        ├── purify.es.mjs.map
        ├── purify.js
        ├── purify.js.map
        ├── purify.min.js
        └── purify.min.js.map

While searching in the Drupal forums, I found the following comment by Nevets →

It mentions: «Drush users can use the command "drush colorbox-plugin"».

Upon running it, Drush responded with:

The colorbox library has been successfully downloaded to /app/web/libraries/colorbox

This installed the required library with the following structure:

./libraries
├── colorbox
│   ├── bower.json
│   ├── colorbox.ai
│   ├── content
│   ├── example1
│   ├── example2
│   ├── example3
│   ├── example4
│   ├── example5
│   ├── i18n
│   ├── jquery.colorbox.js
│   ├── jquery.colorbox-min.js  <===
│   ├── LICENSE.md
│   ├── package.json
│   └── README.md
└── dompurify
    └── dist

After clearing the cache, I was able to see the image in the popup.

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

The issue was due to the required jquery.colorbox-min.js library missing from the libraries folder. The folder structure was as follows:

./libraries
└── dompurify
    └── dist
        ├── purify.cjs.js
        ├── purify.cjs.js.map
        ├── purify.es.mjs
        ├── purify.es.mjs.map
        ├── purify.js
        ├── purify.js.map
        ├── purify.min.js
        └── purify.min.js.map

While searching in the Drupal forums, I found the following comment by Nevets →

It mentions: «Drush users can use the command "drush colorbox-plugin"».

Upon running it, Drush responded with:

The colorbox library has been successfully downloaded to /app/web/libraries/colorbox

This installed the required library with the following structure:

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

The issue was due to the required jquery.colorbox-min.js library missing from the libraries folder. The folder structure was as follows:

./libraries
└── dompurify
    └── dist
        ├── purify.cjs.js
        ├── purify.cjs.js.map
        ├── purify.es.mjs
        ├── purify.es.mjs.map
        ├── purify.js
        ├── purify.js.map
        ├── purify.min.js
        └── purify.min.js.map

While searching in the Drupal forums, I found the following comment by Nevets → :

It mentions: «Drush users can use the command "drush colorbox-plugin"».

Upon running it, Drush responded with:

The colorbox library has been successfully downloaded to /app/web/libraries/colorbox

This installed the required library with the following structure:

./libraries
├── colorbox
│   ├── bower.json
│   ├── colorbox.ai
│   ├── content
│   ├── example1
│   ├── example2
│   ├── example3
│   ├── example4
│   ├── example5
│   ├── i18n
│   ├── jquery.colorbox.js
│   ├── jquery.colorbox-min.js  <===
│   ├── LICENSE.md
│   ├── package.json
│   └── README.md
└── dompurify
    └── dist

After clearing the cache, I was able to see the image in the popup.

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

To replicate the issue, I followed these steps using Drupal 11:

From the Colorbox module directory (modules/contrib/colorbox), I switched to the branch 3475297-does-not-open.
Installed the required DOMPurify library, necessary for the proper functioning of the module, using the following command:
drush colorbox:dompurify
You can verify the installation with the same command:
drush colorbox:dompurify
Created a new content type called "Image page", which includes an image field where the display mode is set to Colorbox.
Created content using this content type, attaching an image.
Upon clicking the image, the Colorbox popup does not open as expected. Instead, the image opens directly in a new tab or window.

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

Hi there,

I'm taking a look at the issue with Colorbox 2.1.1 where links are opening in new tabs instead of a modal. I'll update here once I've made some progress.

Cheers

✨ | Search API attachments | Create extra field for search api attachment content

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

Hi Izus, thank you for your observation and comment.

I conducted the tests by creating a new content type with two file fields (Multi-file Article):

I then created a test content item using this content type:

Both files are displayed correctly in a single view mode, as shown:

However, I noticed a potential issue: if the content of the first PDF file is too lengthy, the entire text is rendered on the page, which may push down or obscure the content of the second file. This behavior might require a solution, such as limiting the displayed content length.

I remain open to any further comments and/or suggestions.

✨ | Search API attachments | Create extra field for search api attachment content

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

✨ | Search API attachments | Create extra field for search api attachment content

🇨🇴Colombia ismaelromero Somewhere in the exotic Colombia

After completing the installation of the module, applying the relevant patch, and configuring both the module and the Apache Tika extractor, I conducted a series of comprehensive tests. The results confirm that it is now possible to utilize file content in view modes.

Below are images illustrating the process and the results obtained:

Article display configuration
Article edit with attached file
Attachment presented as a generic file
Attachment with content displayed

Based on my testing, I can confirm that the requirements are being adequately met.

I welcome any additional comments or suggestions.

✨ | Search API attachments | Create extra field for search api attachment content