- Issue created by @ismaelromero
Hi @ismaelromero,
I have checked the pipeline and re-ran the phpcs job. Confirmed no errors remaining and the job suceeded.
Will now move this to RTBC
Thanks,
Jake
Currently, the module contains inconsistencies in code formatting that do not adhere to the Drupal Coding Standards (Drupal Coding Standards and DrupalPractice). These inconsistencies make the code less readable and can create challenges during code review, in addition to impacting long-term maintainability.
The motivation for this issue is to align the module's code with the recommended standards, making it easier for the community to contribute and ensuring the code is clearer, more maintainable, and compatible with static analysis tools.
By implementing these changes, the module will better align with the Drupal community’s policies, and the effort required for future updates or reviews will be reduced.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css .Fix reported errors and warnings
PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE ERRORS WARNINGS
----------------------------------------------------------------------
...b/modules/contrib/field_group/coding_standard.txt 1 0
...eb/modules/contrib/field_group/field_group.module 5 0
.../src/Plugin/migrate/destination/d7/FieldGroup.php 2 0
...grate/src/Plugin/migrate/source/d7/FieldGroup.php 1 0
...dules/contrib/field_group/src/FormatterHelper.php 1 0
.../modules/field_group_test/field_group_test.module 1 0
----------------------------------------------------------------------
A TOTAL OF 11 ERRORS AND 0 WARNINGS WERE FOUND IN 6 FILESActive
4.0
Code
Hi @ismaelromero,
I have checked the pipeline and re-ran the phpcs job. Confirmed no errors remaining and the job suceeded.
Will now move this to RTBC
Thanks,
Jake