Fix coding standard

Hi @ismaelromero,

I have checked the pipeline and re-ran the phpcs job. Confirmed no errors remaining and the job suceeded.

Will now move this to RTBC

Thanks,
Jake

The function doc comments need to be updated to match the changes.

PHPUnit failed in the pipeline. Is this the cause?

liam morland → made their first commit to this issue’s fork.

It passes on Drupal 11.0 but fails on 11.1 and 10.4. I think there was a change in those two that must be breaking it. I suspect it would also work on 10.3 if it was tested there. This looks like the issue addressed by 🐛 Drupal 10.4 RC1 error with field_ui.js Active .

Thanks for working on this, just tagging with PHP 8.4, to easier follow along.

Works great on the 4.x branch! No deprecation warnings, and Field Group still works.

(People who contributed partial fixes to issues closed as duplicates who should get credit when this is fixed include prem suthar, deepali sardana, MrDaleSmith, and nickdickinsonwilde. And solideogloria who is already over here!)

The diff of issue fork can't be applied to the 3.6 version
The issue Fork 8..x-3 seems to be different of the main issue fork ? what should I apply.
Also got this depreciated but seems not to be resolved by the issue
PHP 8.4 got this depreciated :
Deprecated function : field_group_form_process(): Implicitly marking parameter $form_state as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Deprecated function : field_group_field_group_form_process_build_alter(): Implicitly marking parameter $form_state as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Message Deprecated function : field_group_fields_nest(): Implicitly marking parameter $vars as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Message Deprecated function : field_group_field_layout_fields_nest(): Implicitly marking parameter $vars as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Message Deprecated function : field_group_group_save(): Implicitly marking parameter $display as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

This issue is for fixing coding standards in the 4.x branch.

The "Implicitly marking parameter as nullable is deprecated" message has already been fixed in 4.x. The fix for it in 8.x-3.x is discussed in 🐛 Fix PHP 8.4.x deprecation and other warnings (PHPStan) Active .

LGTM! The PHPUnit failure seems to be related to an ajax tests, which seems to fail randomly. As the test succeeded, right before I added a comment, everything will be fine.
We can tackle the random phpunit failures in a follow-up issue (They also succeed locally).

Reopened to finally also fix eslint in 3490746-fix-eslint

anybody → changed the visibility of the branch 8.x-3.x to hidden.

anybody → changed the visibility of the branch 4.x to hidden.

anybody → changed the visibility of the branch 3490746-fix-coding-standard to hidden.