France 🇫🇷
Account created on 11 March 2011, almost 14 years ago
#

Merge Requests

More

Recent comments

🇫🇷France musa.thomas France 🇫🇷

musa.thomas created an issue.

🇫🇷France musa.thomas France 🇫🇷

sounds good for me thanks for the fix !

🇫🇷France musa.thomas France 🇫🇷

thanks for your answer, my bad the "admin mod" was checked,
it's a bit weird cause when it's not checked:
-the capcthca works normally
-capctcha doesnt disply for admin

when it's checked;
-the captcha is display for admin
-the cacptcha is never validate.

🇫🇷France musa.thomas France 🇫🇷

Yes the client id and secret are ok cause the capatcha display well.
It's just if u set any character the form is submit like set "aaaa" inside input, the webform is submitted

🇫🇷France musa.thomas France 🇫🇷

musa.thomas created an issue.

🇫🇷France musa.thomas France 🇫🇷

@pdureau sorry for the late answer,
"Why footer_partner_link is a component? Can we achieve this witout introducing this unexpected component?"
but th #8 u said :
"3. So, instead or aside of footer_partners component, we may need a new partner_link component with one url prop and one "image" slot:

{{ set attributes = url ? attributes.setAttribute("href", url) : attributes }}

{{ image|add_class(""fr-footer__logo")|set_attribute("style", "height: 5.625rem")
"
Did I misunderstood something ?

🇫🇷France musa.thomas France 🇫🇷

hello I did a test

  "name": "npm-asset/gouvfr--dsfr",
            "version": "1.11.2",

The markup seems have not this attributes group or not grouped accordion

🇫🇷France musa.thomas France 🇫🇷

@Pdureau u right sorry for this, also we have an issue cause the bouton_group pattern include by default the ul li
So:

  1. do we edit and add condition inside the button_group pattern
  2. add new button pattern
  3. hard code the button group tag inside the modal pattern

?

🇫🇷France musa.thomas France 🇫🇷

Sorry forget to look everywhere, should be ok now

🇫🇷France musa.thomas France 🇫🇷

I'm not sure to understand well the backlog, do we need to set to false if it's accordion group or not

🇫🇷France musa.thomas France 🇫🇷

remaining :

the JS file need to be write (it's Copy past from another module

the main idea is copy past (replace input password by text) but we don't know if we put the checkbox by JS

We don't know if we add the checkbox to display the password by the JS or directly inside the twig template

It would be more clean to not have the checkboxe if the Js is not include or enable

Also this checkbox (display password) need to be wrap inside div with the information about password

  <div class="fr-password__checkbox fr-checkbox-group fr-checkbox-group--sm">
    <input aria-label="Afficher le mot de passe" id="password-1144-show" type="checkbox"
           aria-describedby="password-1144-show-messages">
    <label class="fr-password__checkbox fr-label" for="password-1144-show">
      Afficher
    </label>
    <div class="fr-messages-group" id="password-1144-show-messages" aria-live="assertive">
    </div>
  </div>

the fisrt div need to wrap checboxe and the information password message

The information password message is added via JS inside core

Have a look on this file
web/core/modules/user/user.theme.js
web/core/themes/claro/js/user.theme.js

🇫🇷France musa.thomas France 🇫🇷

Musa.thomas created an issue.

🇫🇷France musa.thomas France 🇫🇷

Musa.thomas created an issue.

🇫🇷France musa.thomas France 🇫🇷

Musa.thomas created an issue.

🇫🇷France musa.thomas France 🇫🇷

Musa.thomas created an issue.

Production build 0.71.5 2024