🇫🇷France @musa.thomas

Also need to add x support

After debug it's coming from web/core/modules/media_library/src/Form/AddFormBase.php when the element submit is build, it required a label for aria-label attributes.
The label here is NULL and also produce fatal. This label come from the metadata method of plugin source media. When the getMetadata is calll with $attribute_name='default_name', this value for this key is never defined.
Everything works for exemple if you set default_name=id
I don"t if it's normal or if I miss something in settings ?
I post the patch in case

musa.thomas → created an issue.

musa.thomas → created an issue.

I don't understand cause it's seems already fix in the issue fork the fix is not inside the diff and also I have the 6.0.5 version, I miss something but don't know what

@liam morland sorry but it's literally write "Drupal\migrate_tools\Routing\RouteProcessor::processOutbound(): Implicitly marking parameter $bubbleable_metadata as nullable is deprecated" So what else it can refer to ?

For me

public function processOutbound($route_name, Route $route, array &$parameters, BubbleableMetadata $bubbleable_metadata = NULL):
should be
public function processOutbound($route_name, Route $route, array &$parameters, ?BubbleableMetadata $bubbleable_metadata = NULL):

The diff of issue fork can't be applied to the 3.6 version
The issue Fork 8..x-3 seems to be different of the main issue fork ? what should I apply.
Also got this depreciated but seems not to be resolved by the issue
PHP 8.4 got this depreciated :
Deprecated function : field_group_form_process(): Implicitly marking parameter $form_state as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Deprecated function : field_group_field_group_form_process_build_alter(): Implicitly marking parameter $form_state as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Message Deprecated function : field_group_fields_nest(): Implicitly marking parameter $vars as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Message Deprecated function : field_group_field_layout_fields_nest(): Implicitly marking parameter $vars as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

Message Deprecated function : field_group_group_save(): Implicitly marking parameter $display as nullable is deprecated, the explicit nullable type must be used instead dans include_once() (/var/www/app/web/core/lib/Drupal/Core/Extension/Extension.php ligne 153)

stil have after apply patch

Deprecated function: Drupal\migrate_tools\Routing\RouteProcessor::processOutbound(): Implicitly marking parameter $bubbleable_metadata as nullable is deprecated, the explicit nullable type must be used instead in include() (line 576 of /var/www/app/vendor/composer/ClassLoader.php).

include() (Line: 576)
{closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}() (Line: 427)
Composer\Autoload\ClassLoader->loadClass() (Line: 259)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 430)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 273)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 430)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 237)
Drupal\Component\DependencyInjection\Container->createService() (Line: 445)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 237)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 430)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 237)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 430)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 237)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 430)
Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters() (Line: 237)
Drupal\Component\DependencyInjection\Container->createService() (Line: 177)
Drupal\Component\DependencyInjection\Container->get() (Line: 454)
Drupal\Component\DependencyInjection\Container->{closure:Drupal\Component\DependencyInjection\Container::resolveServicesAndParameters():453}() (Line: 243)
Symfony\Component\EventDispatcher\EventDispatcher::{closure:Symfony\Component\EventDispatcher\EventDispatcher::optimizeListeners():241}() (Line: 206)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 159)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Ok it seems there is a problem wiith the config entity to have colons inside theire name. So it would be better if we can split the machine name of config and also the real name of the tag?

adding temporary patch allowing colons ":" inside machine name, waiting the relataed issue to be resolved

hello there i come from this issue https://www.drupal.org/project/metatag/issues/3498656 🐛 Custom Meta tags: Allow - in the machine name of the tag Active but it seems not to be integrate here. Also we need to insert colon inside the tag name (the regex become 'replace_pattern' => '[^a-z0-9_-:]+',)

hello there,
I read that some people already try this module on D11 but how ? did u download the module then require each dependencies inside the composer.json (also change the .info )?
Should I wait this issue to be ready ?
we need it as soon as possible specially with the end of life of drupal 7 and lots projects require this migration.

musa.thomas → created an issue.

musa.thomas → created an issue.

Hello any update about this features ?

musa.thomas → created an issue. See original summary → .

Add the options widget

musa.thomas → created an issue.

musa.thomas → created an issue.

musa.thomas → created an issue.

musa.thomas → created an issue.

sounds good for me thanks for the fix !

thanks for your answer, my bad the "admin mod" was checked,
it's a bit weird cause when it's not checked:
-the capcthca works normally
-capctcha doesnt disply for admin

when it's checked;
-the captcha is display for admin
-the cacptcha is never validate.

Yes the client id and secret are ok cause the capatcha display well.
It's just if u set any character the form is submit like set "aaaa" inside input, the webform is submitted

musa.thomas → created an issue.

musa.thomas → created an issue.

@pdureau sorry for the late answer,
"Why footer_partner_link is a component? Can we achieve this witout introducing this unexpected component?"
but th #8 u said :
"3. So, instead or aside of footer_partners component, we may need a new partner_link component with one url prop and one "image" slot:

{{ set attributes = url ? attributes.setAttribute("href", url) : attributes }}

{{ image|add_class(""fr-footer__logo")|set_attribute("style", "height: 5.625rem")
"
Did I misunderstood something ?

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.

hello I did a test

  "name": "npm-asset/gouvfr--dsfr",
            "version": "1.11.2",

The markup seems have not this attributes group or not grouped accordion

@Pdureau u right sorry for this, also we have an issue cause the bouton_group pattern include by default the ul li
So:

1. do we edit and add condition inside the button_group pattern
2. add new button pattern
3. hard code the button group tag inside the modal pattern

?

Sorry forget to look everywhere, should be ok now

I'm not sure to understand well the backlog, do we need to set to false if it's accordion group or not

Musa.thomas → created an issue.

Musa.thomas → created an issue.

remaining :

the JS file need to be write (it's Copy past from another module

the main idea is copy past (replace input password by text) but we don't know if we put the checkbox by JS

We don't know if we add the checkbox to display the password by the JS or directly inside the twig template

It would be more clean to not have the checkboxe if the Js is not include or enable

Also this checkbox (display password) need to be wrap inside div with the information about password

  <div class="fr-password__checkbox fr-checkbox-group fr-checkbox-group--sm">
    <input aria-label="Afficher le mot de passe" id="password-1144-show" type="checkbox"
           aria-describedby="password-1144-show-messages">
    <label class="fr-password__checkbox fr-label" for="password-1144-show">
      Afficher
    </label>
    <div class="fr-messages-group" id="password-1144-show-messages" aria-live="assertive">
    </div>
  </div>

the fisrt div need to wrap checboxe and the information password message

The information password message is added via JS inside core

Have a look on this file
web/core/modules/user/user.theme.js
web/core/themes/claro/js/user.theme.js

Musa.thomas → created an issue. See original summary → .

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.

Musa.thomas → created an issue.