- Issue created by @musa.thomas
- Merge request !95Issue #3459944: [1.0.1] DSFR 1.11: Remove ul li from the actions footer ā (Open) created by musa.thomas
- Status changed to Needs review
9 months ago 12:38pm 8 July 2024 - First commit to issue fork.
- Status changed to Postponed: needs info
9 months ago 9:07am 11 July 2024 - š«š·France pdureau Paris
I am not sure I understand the change.
In the preview, you removed
button_group
so thebutton
components are now directly injected into:<div class="fr-modal__footer"> {{ actions }} </div>
But the upstream issue (which is not clear, I admit) seems to tell to keep them: https://github.com/GouvernementFR/dsfr/pull/720
And the up-to-date documentation too: https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/m...
- š«š·France musa.thomas France š«š·
@Pdureau u right sorry for this, also we have an issue cause the bouton_group pattern include by default the ul li
So:- do we edit and add condition inside the button_group pattern
- add new button pattern
- hard code the button group tag inside the modal pattern
?
- š«š·France pdureau Paris
Indeed, there may be an issue here, but in upstream
component expects UL & LI in markup: https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/g...
Modal component, use , but don't expects UL & LI https://www.systeme-de-design.gouv.fr/composants-et-modeles/composants/m...
3 options:
- 'add condition inside the button_group pattern'
- "hard code the button group tag inside the modal pattern"
- do nothing, because upstream issue, not ours
- Status changed to Closed: works as designed
5 months ago 4:02pm 28 October 2024 - š«š·France pdureau Paris
do nothing, because:
- upstream issue, not ours: lack of consistency
- tested with the browser dev tool on https://main--ds-gouv.netlify.app/example/component/modal/ and it is also OK on modal with UL/LI