- Issue created by @musa.thomas
- First commit to issue fork.
- Assigned to spryah
- Issue was unassigned.
- Status changed to Needs review
8 months ago 2:54pm 3 September 2024 - Status changed to Needs work
8 months ago 9:43pm 4 September 2024 - 🇫🇷France pdureau Paris
Hi, thanks for the MR
First look: you need to use the attribute object and add a default filter for title_tag in the template
- 🇫🇷France pdureau Paris
You need default values for
current_step
andsteps
, because this part of the display looks empty if the values are missing :<div class="fr-stepper__steps" data-fr-current-step="{{ current_step|default(1) }}" data-fr-steps="{{ steps|default(1) }}"></div>
Careful, I have rebased your remote branch)
- 🇫🇷France pdureau Paris
Also, I was wondering about this :
{% if detail %} <p class="fr-stepper__details"> <span class="fr-text--bold">{{ 'Next step:'|t }}</span> {{ detail }} </p> {% endif %}
fr-text--bold
doesn't look like a part of thestepper
component because it is a utility class instead of a element (as BEM) class. But, because "Next step" is hardcoded, I am OK to let it like that. What do you think?However, it seems we are not implementing those 2 rules:
- Le nombre maximal d’étapes proposées dans le composant est limité à 8.
- À la dernière étape, le titre de l'étape suivante n’est pas à afficher.
- 🇫🇷France just_like_good_vibes PARIS
i don't understand why the state is not a fixed string and a slot instead?
- 🇫🇷France pdureau Paris
This is not "Twigy":
{% if not current_step is defined %}{% set current_step = 1 %}{% endif %} {% if not steps is defined %}{% set steps = 2 %}{% endif %}
This is better:
{% set current_step = current_step|default(1) %} {% set steps = steps|default(2) %}
-
just_like_good_vibes →
committed 99801607 on 1.0.x authored by
spryah →
Issue #3460549 by spryah, pdureau, just_like_good_vibes: Add stepper...
-
just_like_good_vibes →
committed 99801607 on 1.0.x authored by
spryah →