🇫🇷France @just_like_good_vibes

just_like_good_vibes → created an issue.

pdureau → credited just_like_good_vibes → .

let's try to write also the presenter templates for tables in views, like it is done in ui_suite_bootstrap.

just_like_good_vibes → created an issue.

this fix has been pushed and re-pushed again until we finally have it now with a clean dependency to a required ui_patterns min version.
finally... but this is not finished, we will follow-up - in that issue or not? - performances issues introduced now.

and finally :)

Hello rajab natshah,
thanks to your issue, we though to introduce a more deeper support for tokens in ui patterns sources.
so we will introduce a shared code to deal with tokens here : https://www.drupal.org/project/ui_patterns/issues/3540970 📌 [2.0.8] Enlarge the support of tokens in sources Active

just_like_good_vibes → created an issue.

thanks

just_like_good_vibes → made their first commit to this issue’s fork.

hello,
thank you for your work, indeed this is a nice usecase :)
Today we have some code in Token source, if we plan to generalize it in other sources like Attributes, it would be good to rely on the same code in those sources.
i suggest that factorize some appropriate code about tokens, somewhere.
In a trait or directly in the SourcePluginBase ? @Christian, others, what do you think ?

do we need tokens elsewhere? maybe yes.

i posted an update of the code which seems to correct the issue,
but this issue in ui_patterns is needed : https://www.drupal.org/project/ui_patterns/issues/3540835 🐛 [2.0.8] correct ChoiceSettings for Component source Active

just_like_good_vibes → created an issue.

here we are, ready for review :

- we have a new interface for those sources with a choice. It allows them to expose those choices to the outside world.
- we have improved the returned label of sources, in those particular cases of sources with choice.

just_like_good_vibes → changed the visibility of the branch 3513568-2.0.3-source-usability to hidden.

hello,
sorry trimming here is not appropriate :)
we need to cope with this edge case in a better way.

just_like_good_vibes → made their first commit to this issue’s fork.

just_like_good_vibes → made their first commit to this issue’s fork.

i found this line in ui_patterns_ui (UiPComponentFormDisplaysForm)

$component_id = $element['#component_id'] ?? $element['#default_value']['component_id'] ?? NULL;

and we have this line in ui_patterns (ComponentFormBase)

$component_id = $element['#default_value']['component_id'] ?? $element['#component_id'] ?? NULL;

we need to sort this out

ready for merge

just_like_good_vibes → made their first commit to this issue’s fork.

Hello,
we are still discussing again and again ( ;) ) the model for this component.

- do we introduce a Row component or not ?

We vote for yes, because it will be more obvious for users,
and easier to use in views.

But, we notice this is not technically required !

let's add table_row and finish this work :)

just_like_good_vibes → made their first commit to this issue’s fork.

just_like_good_vibes → made their first commit to this issue’s fork.

just_like_good_vibes → made their first commit to this issue’s fork.

just_like_good_vibes → made their first commit to this issue’s fork.

just_like_good_vibes → created an issue.

just_like_good_vibes → changed the visibility of the branch 3401866-error-with-mbstrlen to hidden.

just_like_good_vibes → made their first commit to this issue’s fork.

pdureau → credited just_like_good_vibes → .

hello, if you haven't enabled the module (just required using composer), then this cannot be the cause of your issue.
but when you did the composer require command, maybe you have updated some already enabled extensions in your drupal install.
From the trace i saw here in the issue, it looks like you have an SDC component with a "bad" definition. BAd in a sense that the component validator is raising an exception.

you can try sdc_devel module to help, i would advice to go to drupal slack too just in case.

just_like_good_vibes → created an issue.

pdureau → credited just_like_good_vibes → .

pdureau → credited just_like_good_vibes → .

just_like_good_vibes → made their first commit to this issue’s fork.

let's not forget to use sdc_devel

pdureau → credited just_like_good_vibes → .

we are maybe not ready yet, but we are taking a specific direction, that would be good to validate the direction :)
for example for props being array of attributes

just_like_good_vibes → created an issue.

g4mbini → credited just_like_good_vibes → .

as discussed, we will merge stories form replaced component and replacer

We will probably use empty string for the value of "source_id", to allow the source selector to appear.
but, in the future, more functionalities may be introduced to control what is shown.

We are ok that this change allows to show the source selector, and it is for site builders :)

just_like_good_vibes → created an issue.

just_like_good_vibes → created an issue.

just_like_good_vibes → created an issue.

just_like_good_vibes → created an issue.

just_like_good_vibes → created an issue.

just_like_good_vibes → created an issue.

just_like_good_vibes → created an issue.

As we discussed,
it would be better to have two new methods in the decorated sdc service, to be able to get SortedDefinitions and getGroupedDefinitions with replacements.

we need nice names :)

Hello,
just to add some information about the current implementation, i am questioning here the way it is done,
in comparison to the code in SystemMenuBlock::build

we could use menuTree->getCurrentRouteMenuTreeParameters(,
any thoughts?

just_like_good_vibes → made their first commit to this issue’s fork.

i am still hesitant because the bug seems triggered by the usage of ui_patterns_ui, and we are trying to fix it in ui_patterns.

just_like_good_vibes → made their first commit to this issue’s fork.