- Issue created by @pdureau
- First commit to issue fork.
- 🇫🇷France pdureau Paris
You may need the new Links settings type introduced by https://www.drupal.org/project/ui_patterns_settings/releases/8.x-2.1 →
- 🇫🇷France spryah
We put this issue on hold because the DSFR maintainers have yet to release a fix that will allow developers to define sub-partners without having to define a main partner (it shouldn't be long now)
- Status changed to Postponed
over 1 year ago 9:58am 4 November 2023 - Status changed to Active
about 1 year ago 12:26pm 25 January 2024 - 🇫🇷France pdureau Paris
We put this issue on hold because the DSFR maintainers have yet to release a fix that will allow developers to define a list of (sub) partners without having to define a main partner (it shouldn't be long now)
3 month later, it seems it is not done yet upstream: https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/pi...
Logo du partenaire principal, ferré à gauche - obligatoire
Logos des partenaires additionnels, ferrés à droite - optionnels. - 🇫🇷France pdureau Paris
Some thoughts...
1. Do we still do a separate component considering 📌 [beta6] ⚠️ Merge footer_top & footer_menu into footer component? Postponed ?
2. It will not be easy to convert main & sub slots to "links" props because of the images.
3. So, instead or aside of
footer_partners
component, we may need a newpartner_link
component with one url prop and one "image" slot:{{ set attributes = url ? attributes.setAttribute("href", url) : attributes }} <a{{ attributes.addClass("fr-footer__partners-link") }}> {{ image|add_class(""fr-footer__logo")|set_attribute("style", "height: 5.625rem") </a>
- Assigned to musa.thomas
- Issue was unassigned.
- Status changed to Needs review
9 months ago 1:26pm 9 July 2024 - Assigned to pdureau
- Issue was unassigned.
- Status changed to Postponed
9 months ago 9:05pm 15 July 2024 - 🇫🇷France pdureau Paris
Why
footer_partner_link
is a component? Can we achieve this witout introducing this unexpected component? - 🇫🇷France musa.thomas France 🇫🇷
@pdureau sorry for the late answer,
"Why footer_partner_link is a component? Can we achieve this witout introducing this unexpected component?"
but th #8 u said :
"3. So, instead or aside of footer_partners component, we may need a new partner_link component with one url prop and one "image" slot:{{ set attributes = url ? attributes.setAttribute("href", url) : attributes }}
{{ image|add_class(""fr-footer__logo")|set_attribute("style", "height: 5.625rem")
"
Did I misunderstood something ? - Assigned to just_like_good_vibes
- Status changed to Needs work
13 days ago 10:00am 20 March 2025 - 🇫🇷France pdureau Paris
One year later, I am not that sure this must be it's own component instead of just an addition to the footer component.