Fatal on decode JSON with a token

It feels like we shouldn't spend more time in trying to capture the ambiguous function declaration of that encode plugin from the tamper module. We went back and forth with trying to be smart about data types where that method just wants either string or array, depending on settings, but doesn't provide any means to validate the provided data. There has been an issue where it was suggested to break that plugin apart and be very specific about data types.

I think this is indeed a bug in the Tamper module. The encode plugin says that it accepts an array, but then passes that to json_decode() which only accepts a string.

Planned to be fixed in ✨ Create separate Decode-plugin RTBC . Feel free to share your thoughts there.

A fix has been implemented in ✨ Create separate Decode-plugin RTBC . Reviews there are welcome!

After setting the referenced issue to RTBC, I've also reviewed our eca_tamper wrapper implementation and I think that we can close this issue, as this seems to be working as expected when the other one gets released.

We already makes sure, that the following modes will provide a string to the tamper method:

        'base64_encode',
        'unserialize',
        'json_decode',
        'base64_decode',
        'yaml_decode',

For all others, we pass on whatever we receive, either scalar or array. Please, feel free to re-open if I'm mistaken.

Automatically closed - issue fixed for 2 weeks with no activity.